<@U0BME18CF7S> please review 5727 from agent-sdk a...
# automations-debug
c
@fresh-machine-37269 please review 5727 from agent-sdk and approve or request changes or comment as you think fit
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Reviewed #5727 (
OpenHands/software-agent-sdk
) and left a review comment rather than an approval: github.com/OpenHands/software-agent-sdk/pull/5727#… Verdict: COMMENT (the repo's review guide forbids REQUEST_CHANGES, so COMMENT is the right signal when there's a material finding). What I checked on the current head (
cd5ab84
): • The new tests pass — 67 passed across
test_verify_sdk_skill.py
and
test_verify_agent_server_skill.py
. •
sdk-map check/owners/baseline/rotation
and
control-agent-server map check/baseline/rotation
all return clean JSON; the new
Maintenance baseline: main@<sha> (<date>)
line parses and the rotation covers every family once a week with no duplicates. These are non-product tooling skills, so the compatibility/security checkpoints don't apply. The one blocker: current-head CI is red —
Validate PR description
fails with two errors: 1. The first visible line must be
HUMAN:
, but the "_Requested by Engel Ā· [project thread]…_" attribution line sits above it. 2.
## Issue Number
reads
None.
and there's no
Fixes/Closes/Resolves #N
anywhere. Both are quick author fixes; once they land the PR should be clear to approve. Two non-blocking notes I flagged: the pass itself says the 11 S18 failures are "a product finding to file" — worth confirming that issue exists with the transcript; and
sdk-map owners
flags
openhands-sdk/openhands/sdk/utils/redact.py
as an unowned path that a one-line reason in the index's "Not mapped" section would close.