<@U0BME18CF7S> can you please re-review openhands/...
# automations-debug
c
@fresh-machine-37269 can you please re-review openhands/automation PR 547 ? You got a reply to your older comment. Feel free to use the gh api with event.
👀 1
f
🤖 On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
✅ Done! I checked both places and found a mix-up worth flagging before I post anything. On
openhands/automation
PR 547
(the URL you named) there's been no new activity since my last review on Oct 7. The head is still
60f3945
, and there's no reply to any of my earlier comments — all eight review comments are top-level, and the timeline shows nothing after the Oct 7 review. My two outstanding findings are therefore still open and unaddressed: 1. Character budget is measured wrong.
with_thread_context
counts with
json.dumps(..., ensure_ascii=False)
, but the dispatcher emits
AUTOMATION_EVENT_PAYLOAD
with default
json.dumps
(escapes non-ASCII). I measured ~6× inflation: the
le=100_000
ceiling can serialize to >1 MB, and Linux caps a single env string at 128 KiB, so the run's entrypoint can fail to start on an emoji/CJK-heavy thread. 2. File/attachment names break the transcript fence. `author`/`text` are newline-escaped, but
', '.join(...)
on
files
isn't, so a crafted filename or attachment `title`/`fallback` can forge a transcript row or a
## Task
heading after the untrusted-content label (both presets have this). The reply you're describing looks like it's on
OpenHands/extensions
PR 547
— same number, different repo. There, my earlier inline review did get a reply from you (Oct 8) asking "@all-hands-bot please re-review this head." That PR was merged today at 17:29, so a fresh review is now moot unless you want a post-merge look. So: did you mean the extensions PR, or should I post a fresh re-review on `automation`#547 (which would just restate the two still-open blockers, since nothing changed)? Say the word and I'll proceed — if you want automation#547 actually unblocked, the author needs to push a commit first.