<@U0BME18CF7S> please review the PRs in this image...
# automations-debug
c
@fresh-machine-37269 please review the PRs in this image. for each, feel free to approve. request changes, or comment, as you think appropriate.
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! I wasn't able to open the screenshot you attached — image attachments to me aren't coming through, so I can't see which PRs are in it, and I don't want to guess at approvals/review comments on the wrong ones. Could you either: • paste the PR links directly (as you've been doing in this channel), or • re-share the image and I'll take another look? Once I can see the PRs, I'll happily go through each one and approve, request changes, or leave a comment as appropriate.
c
@fresh-machine-37269 they are 18199 18200 18194
šŸ‘€ 1
f
Reviewed all three šŸ‘‡ • 18199 — fix: use theme colors for form validation → āœ… Approved. Clean token migration (
text-red-400/500
→ `text-danger`/`border-danger`), no behaviour change, and the test now asserts the visible outcome instead of a palette class. CI green. • 18194 — chore(lint): protect divider/toggle appearance contracts → šŸ”“ Changes requested. The config scoping and the new rule test look good, but the
Validate PR description
check is failing on the head (multiple runs, not a flake) — please fix the description so it goes green. Minor note on test/probe line-number coupling is non-blocking. • 18200 — feat: add compact section navigation on tablets → šŸ”“ Changes requested. Two things: 1. The branch is conflicted (
dirty
).
main
just merged #18211, which already adds
browser record
for video capture in the same `browser-daemon.mjs`/`control-openhands.mjs`/`SKILL.md` files — this PR's
CONTROL_OPENHANDS_VIDEO
+
browser video
is a parallel implementation. Needs a rebase onto the merged verb, not a second recording path. 2. The settings selector finds the current section with an exact path match, so on nested routes (e.g.
/settings/llm/...
) it renders nothing and silently disappears. The extensions selector already handles this with a
startsWith
fallback — worth matching. The UI/component work and test coverage are solid otherwise.
āœ… Done! Done — here's what I posted on each: • #18199 (theme colors for validation) → āœ… Approved. Clean
red-400/500
→ `text-danger`/`border-danger` migration, no behaviour change, and the test now checks the visible outcome rather than a palette class. CI green. • #18194 (lint: divider/toggle appearance contracts) → šŸ”“ Changes requested. Config scoping and the new rule test look right, but the
Validate PR description
check is failing on the head (repeatedly, not a flake) — needs fixing before merge. • #18200 (tablet compact section navigation) → šŸ”“ Changes requested. The branch is conflicted:
main
just merged #18211, which already adds
browser record
for video capture in the same `browser-daemon.mjs`/`control-openhands.mjs`/`SKILL.md` files, so this PR's
CONTROL_OPENHANDS_VIDEO
+
browser video
duplicates it and needs a rebase. Also flagged that the settings selector's exact-path lookup makes it vanish on nested routes (e.g.
/settings/llm/...
), unlike the extensions selector. The component work and tests are solid otherwise. Each review also has the full detail (with the AI-agent disclosure) on GitHub.
c
@fresh-machine-37269 18200 was fixed, re-review please, and 18194
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Thanks! I took a fresh look at both. #18194 — good to go āœ… The only blocker last time was the red
Validate PR description
check. That's now green on the current head (
d0312fdd
), and everything else about it still holds up — the scoping of
no-restyle
to
#/ui/(divider|toggle-switch)
, the
allow: ["layout"]
(plus
opacity
on
ToggleSwitch
), turning the rule off inside
src/ui
, and the new
restyle-lint
test all look right. Nothing left blocking — consider it approved. #18200 — not ready for re-review yet ā›” This one still carries the same blocker I flagged, and I don't see any new commits on the branch since the last review (tip is still
a4433b2ecc
, last commit from before that review). Concretely: • It's still conflicted against
main
(
mergeable_state: dirty
). #18211 (
browser record
) merged at 02:19, and this branch still ships its own parallel recording implementation —
CONTROL_OPENHANDS_VIDEO
in
browser-daemon.mjs
, plus the
browser video
verb in
control-openhands.mjs
and the matching
SKILL.md
section. It needs a rebase that reconciles onto the merged
browser record
verb instead of reintroducing a second path (which also drops the changes to those two scripts and the SKILL.md video section). • The design question is also still open:
SettingsCompactNavigation
still derives
currentLabel
with exact
<http://item.item.to|item.item.to> === currentPath
, so nested sub-pages (e.g.
/settings/llm/...
) return
null
and the selector disappears.
ExtensionsCompactNavigation
already handles this with `startsWith(\`${item.to}/`)`. So: #18194 looks clean, but #18200 needs the rebase/reconcile plus that lookup tweak. Ping me once those are in and I'll take another pass. This reply was generated by an AI agent (OpenHands) on behalf of the maintainers.
c
@fresh-machine-37269 thanks, approve 18194 then :)
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Done — I approved #18194 ("chore(lint): protect divider and toggle appearance contracts"). My earlier blocker is cleared: the latest
Validate PR description
run on the head commit is green (only the superseded runs are red), and CI passes. I kept the one non-blocking note that the tests pin exact line numbers/ordering, so the probe will need touching whenever it's edited.