https://docs.all-hands.dev/ logo
Join Slack
Powered by
Small PR removing `condenser_kind` from the Settin...
# proj-agent
c
Small PR removing 
condenser_kind
from the Settings schema: https://github.com/OpenHands/software-agent-sdk/pull/5531 I'd love to know if there are concerns about this 🤔 I had the agent run a canvas on this sdk just in case, to make sure to surface issues (still working)
❌ 1
m
left a couple of comments
👀 1
c
Worth a bit of thinking... Maybe it's actually not worth the complexity. Likely nobody has chosen "no op" because they care about keeping "condenser enabled but no op", I mean... it's unlikely this is a thing, it just looks like the code technically allows for such case
@modern-fireman-99755 @limited-student-10747 For clarity, users had 2 ways of disabling condensing: • the Enable Memory Condensation setting -> disable • enable it -> and set a "no-op" condenser. This looks to me like a redundancy, 2 confusing ways of getting the same result in the end. IMHO, we should remove the UI ability to set "no-op". I think maybe a one-time migration of settings can be useful, from "no-op" to "disabled". I don't know if doing the same in Agent Profiles is useful, APs only got this recently, do we really believe that people Enable and then set no-op in APs? Seems unrealistic to me, and IMHO the trade-off with code complexity is worth thinking about.
Conversely, we could remove the Enable setting. I think that makes it ... unlike agent kind? I don't know. Might be worth considering
m
I do agree with you I'm not sure why we have the no-op condenser in the sdj
l
I don’t think we want to remove the condenser kind setting because we may have different condenser in the future. But at the same time noop condenser is not very interesting. I’d prefer to keep it as-is for now and then maybe think about adding a new condenser, like the jev-powered masking condenser, as another option. Also this paper is pretty promising: arxiv.org/abs/2609.26779
c
Ah, for sure... Speaking of which, I'm experimenting with another condenser, too, where the agent decides to save its own notes, and call a 
condense
tool when it's ready
Maybe another solution is to give up the NoOpSettings, if possible... not sure. I closed the PR for now
Open in Slack
PreviousNext
Powered by