Found this debugging a local canvas that kept free...
# proj-agent
m
Found this debugging a local canvas that kept freezing: the agent-server deadlocks against itself resolving secrets while masking. Happy to take a different approach if you prefer the async-dispatch route described in Notes 🙂 Issue: github.com/OpenHands/software-agent-sdk/issues/5200 PR: github.com/OpenHands/software-agent-sdk/pull/5201
@calm-artist-7206 🙂
c
Will take a look tomorrow, sorry - generally FWIW on this kind of issue what I care about is code cleanliness/simplicity -ish, because I believe we need to redesign and reimplement secret store, which likely means removing these
I see we merged the other PR
According to Astra, it’s a fix for local, but apparently not for external (cloud) URLs
m
do you mean my fix or the one which was merged? I think the one which was merged was somewhat better
c
nod agreed, it’s just not clear it solves it for all scenarios
I could be wrong; worth testing on cloud when this version of sdk goes out I guess