Updated the PR for light mode, needs a reviewer no...
# proj-agent-canvas
a
Updated the PR for light mode, needs a reviewer now: github.com/OpenHands/OpenHands/pull/16632
👀 1
b
Let me review next week before merging!
🙌 1
m
Could you solve the conflicts? 🙂
👍 1
b
So there's still a number of components I'm seeing that need to be worked on, some hover states in dropdowns are also not visible, some buttons are missing contrast with the background, some icons are white on grey, the notifications are white text on grey backgrounds, some dividers are too feint and lacking contrast against the background. These problems are across both the new Light+ and the Solarized theme. I'd like to ask that we postpone merging until these get fixed as it breaks the UI. I don't have time this week to do a thorough pass on all pages, all modals, etc. this week given the need to work on OHE2 work. I'm all for these themes going in but they still need work and a designer's eye.
a
(I don't think anyone for now is going to notice the light theme except for me - i have been happily using it)
@breezy-kilobyte-39430 do you want my agent to take another shot at it based on your feedback? or just pause for now?
b
Sure, take another shot, it'll still need a complete human review though.
a
Absolutely on the human review. Might see what opus 5.5 can add here.
🙌 1
I had my agents take another pass at this, hopefully it will be in much better shape for the human review: github.com/OpenHands/OpenHands/pull/17730
b
image.png
I got them in the new engine
@average-processor-75195
a
oh wow! can I can have a really good light mode
b
@average-processor-75195