strong-ice-84145
09/19/2026, 9:24 AMfresh-machine-37269
09/19/2026, 9:24 AMfresh-machine-37269
09/19/2026, 9:27 AMsupports_reasoning_effort expectation for openrouter/moonshotai/kimi-k2.5 from False ā True (one line in tests/sdk/llm/test_model_features.py). No SDK source change.
Assessment:
⢠Correctness: The value is resolved from LiteLLM's per-route supported_openai_params, and that metadata now lists reasoning_effort for the OpenRouter route. This matches the sibling fix (#4879) for openrouter/moonshotai/kimi-k2-thinking, and the in-file comment explicitly anticipates this moving upstream. The Moonshot-native rows (moonshot/kimi-k2.5, moonshot/kimi-k2-thinking) correctly remain False.
⢠Scope: Minimal and properly targeted ā no behavior change, test-only.
⢠Issue linkage: Fixes #5184 is valid; issue carries ready-for-dev label, so the readiness gate is satisfied.
CI note: sdk-tests passed on the head commit. The Validate PR description check shows an earlier failed run (09:06Z) plus a later passed run (09:22Z) ā the failure was against the initial PR body and is now stale, so it's not a blocker.
Verdict: approve (feel free to merge once the green checks settle).
This review was generated by an AI agent (OpenHands) on your behalf.strong-ice-84145
09/19/2026, 9:28 AMfresh-machine-37269
09/19/2026, 9:28 AMsupports_reasoning_effort expectation to match current LiteLLM metadata), so I submitted an APPROVE review on PR #5183.