<@U0BME18CF7S> please review <https://github.com/O...
# automations-debug
c
@fresh-machine-37269 please review https://github.com/OpenHands/software-agent-sdk/pull/5105 and approve if it’s clean, we need it on release pr
πŸ‘€ 1
f
πŸ€– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
βœ… Done! Approved βœ… The diff is clean β€” it removes the deprecated
GET /api/desktop/url
stub (
desktop_router.py
), its registration on both the app and runtime routers, and the tests that pinned the stub plus the stale OpenAPI entry. No server-side references remain, so it unblocks the v1.49.0 deprecation-deadline check. One non-blocking note: the TypeScript client (
desktop-client.ts
) still has a
DesktopClient.getUrl
pointing at that endpoint, but it was already dead (always 503), so no behavior change β€” worth a follow-up cleanup.
c
@fresh-machine-37269 fix the ts client too please
πŸ‘€ 1
f
βœ… Done! Done βœ… I fixed the TypeScript client to match the server-side removal of
GET /api/desktop/url
. What changed (44 deletions, 6 files): β€’ Deleted
clients/typescript/src/client/desktop-client.ts
β€’ Removed
DesktopClient
wiring from
openhands-client.ts
and
conversation-manager.ts
(import/field/instantiation/`close()`) β€’ Removed its exports from
clients.ts
(
DesktopClient
,
DesktopClientOptions
) β€’ Removed
DesktopUrlResponse
from
models/api.ts
and its
index.ts
export Verified green: β€’
npm run build
(tsc) βœ“ β€’
npm test
β€” 328/328 βœ“ β€’
npm run lint
β€” 0 errors βœ“ β€’
npm run format:check
βœ“ β€’
npm run check:public-type-budget
β€” unchanged βœ“ One caveat I need to flag: this PR has
maintainerCanModify
disabled, so my bot account (
all-hands-bot
) can't push to your
enyst/agent-sdk
fork branch
. Instead I: 1. Pushed the fix to
OpenHands/software-agent-sdk:openhands/fix-5105-ts-desktop-client
, and 2. Left a comment on the PR (with the full diff and test evidence) explaining how to cherry-pick
584c4b00
. So it's ready to merge β€” either cherry-pick that commit onto the PR branch, or I can open a separate PR against the same base if you'd prefer. Note I left the auto-generated
DesktopUrlResponse
in
src/generated/agent-server-schema.ts
alone, since it's regenerated from the pinned
agent-server:1.47.0
OpenAPI and will disappear on the next version bump.