<@U0BME18CF7S> please review <github.com/OpenHands...
# automations-debug
s
@fresh-machine-37269 please review github.com/OpenHands/OpenHands/pull/17423 and approve if it's safe to merge
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! I reviewed PR #17423 and approved it — it's safe to merge. Summary of what I verified: •
@openhands/typescript-client
bumped
1.39.0 → 1.46.0
, correctly matching `versions.agentServer`;
package.json
and
package-lock.json
are in sync. • The codex shim is fully removed (no dangling references to
resolveCodexDefaultCommand
,
CODEX_ASTRA_MODEL
, or
CODEX_LEGACY_ACP_COMMAND
at the head commit). • The new CI gate (
findClientPinMismatch
) runs offline/first, rejects range pins, and normalizes versions correctly, with
package.json
added to the workflow's path filters. • Live E2E evidence in the PR confirms a real Codex ACP conversation launches on the registry-derived command with a verified tool-call result. āš ļø One caveat:
test-and-build (ubuntu)
is still in progress (the windows variant, SDK-version-sync check, lint, typecheck, and builds are all green). My approval is on the diff itself — worth confirming that last ubuntu job goes green before hitting merge.