https://docs.all-hands.dev/ logo
Join Slack
Powered by
<github.com/OpenHands/automation/pull/438> - suppo...
# proj-automation
q
github.com/OpenHands/automation/pull/438 - support for draft automations and test runs its a stacked pr
👀 1
cc @calm-artist-7206 or @modern-fireman-99755 for review
c
Thank you for this! I went through with Astra to see what it can find, I posted a comment. It’s actually interesting and not all obvious, it seems to me
q
Seems like good feedback, if there are tests that it wrote it would be great to have them as part of the pr
c
nod on it
ty 1
On a side note, this is what I’m starting to like… : an agent (with different context and maybe LLM than the implementor agent) explains behavior. Behavior, not the raw diff of the code. And then we review behavior (and code design, which is still a bit hard but we’ll get it 🙏)
nod 1
m
I will give a look at it 😉
c
On 439: • <f31ae3a2be817b45acfe535c2abd0e9a4494abbf|add failing draft execution> On 438: • <99cc5d37e12fc2f589110db0f975d5082a78c43c|add failing lifecycle and migration>
I didn’t stop it on Point 4, but I think we could flip that around
q
ready for another look
m
ah actually I forgo to look into that... Sorry I will do now
Left some comments
ty 1
q
addressed!
m
it is good for me
q
its a stacked pr, did you have a chance to look at the second one?
@modern-fireman-99755 the second pr's review comments have already been addressed
m
Hey, reviewed the second PR. Just a couple of comments. Nothing important. Please tag me for another review
ty 1
2 Views
Open in Slack
PreviousNext
Powered by