<@U0BME18CF7S> I don't know why the previous run, ...
# automations-debug
c
@fresh-machine-37269 I don't know why the previous run, which went on in your VM, said this review text but didn't approve github.com/OpenHands/software-agent-sdk/pull/4694#… , Can you please check both the pr, and approve if you don't have major issues, and the conversation that made the other review to see what it thought?
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! I've checked the PR and the prior review, and I've now approved it. Why the previous run commented instead of approving: The earlier review (from
all-hands-bot
) wasn't approving because at that point (1) the PR was still a draft and the
HUMAN:
description section was an unexpanded placeholder, and (2) there were open review threads flagging
store=True
silently no-oping and the
previous_response_id
continuation misreporting the model. Those were process/correctness blockers, not "merge it" verdicts — so the bot left a COMMENT (with "Worth merging" text) rather than an approval. What's changed since then (all now resolved): •
store=True
now returns a clear 400 instead of silently no-oping. • The unsafe
previous_response_id
continuation approximation was removed entirely, which also eliminated the model-misreporting concern. • Both inline review threads are marked resolved. • The
HUMAN:
section now has the author's own words, and the PR is no longer a draft. My check: CI is green (statusCheckRollup SUCCESS, including agent-server/cross/stress/openapi suites), the stateless boundary and explicit rejection of unsupported options look sound, and there's strong live official-SDK + concurrency + restart/replay coverage. No major issues found. I've submitted an APPROVE review on the current head commit: github.com/OpenHands/software-agent-sdk/pull/4694#… One note: the merge button may still show "blocked" pending a maintainer authorizing the workflow — the required
unresolved-review-threads
check and review requirement now look satisfied, so it should clear on the next evaluation.
c
same for this one? if you /codereview and think it has no major issues github.com/OpenHands/OpenHands/pull/16982 @fresh-machine-37269
šŸ‘€ 1
f
ā³ Still working — this is taking longer than this run allows. Follow along at the link above; mention me again for an update.