https://docs.all-hands.dev/ logo
Join Slack
Powered by
Socket mode for slack in automations: <feat: add i...
# proj-automation
m
Socket mode for slack in automations: feat: add in-service Slack Socket Mode via a supervised stream transport The oss-openhands bot is running on this code 👇
❤️ 1
c
I'll defer to Rohit for the Automations. I was reading around, on the related issues, and would like to attract your attention here: comment
I think maybe the agent kinda came to the same conclusion, but it also got into the weeds on guessing the SDK behavior 😅
The relevant point, it seems to me, is that I don’t think we need to store a mapping. We can make do with a clear, documented, deterministic rule to decide the conversation’s ID.
m
Thanks... So I look inside the PR associated of the issue and yes it seems that we can simplify a little bit. 🙂 The PR is: github.com/OpenHands/automation/pull/385 I'm still testing a bit but it seems to be good.
PS: please ignore the comments into the issue. Just the agent posting stuff so I (and the agent) don't forget
c
Re: the code like 
continue_conversation
or the lock, do they seem necessary because of the Cloud backend specifics, or are they necessary with a local/remote agent-server?
m
Yes Cloud BE can have a race condition. But for local should be fine
@quick-window-91705 Could you give a look to the above PR please when you have a moment?
👍 1
q
left a couple of comments for slack streams, overall lgtm
Heads up that for conversation reuse I had previously proposed this: github.com/OpenHands/automation/issues/105 Haven't taken a look at Vascos implementation yet, will do so soon
👀 1
m
Ah sorry I didn't see the issue...
But yes let's compare
Open in Slack
PreviousNext
Powered by