https://docs.all-hands.dev/ logo
Join Slack
Powered by
small favor if anyone here has a moment: I just ne...
# proj-agent-server
c
small favor if anyone here has a moment: I just need 
ready-for-dev
on github.com/OpenHands/software-agent-sdk/issues/4577 to unblock my PR.
l
Hey @clean-greece-29346, I think you can just ask your agent to modify the description so that it’s ready-for-dev
c
Oh, I thought I already did that. Is the GitHub Action supposed to label it automatically? Maybe I missed something.
looks like I did. looking into it now
l
I guess you only have 2 sharps but need 3, we should make that less strict 😅
c
ohhhhhhhhh
yeah my agent caught it as I was reading your message.
good to know that should happen automatically. I'll just look closer next time. thanks for the help @limited-student-10747 @calm-artist-7206
l
@fresh-machine-37269 open a ready-for-dev issue saying that the ready-for-dev github action is too strict
👀 1
f
🤖 On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
c
It seems to happen a lot when the agent creates the issue without using a template, but I think we tweaked prompts just today
f
✅ Done! Done! Opened github.com/OpenHands/software-agent-sdk/issues/4631 — it explains how the 
ready-for-dev
action only recognizes 
###
(h3) headings (the 
HEADING_RE
regex hard-codes 
^###
), so an issue using 
##
headings (like #4577) gets wrongly flagged as missing sections, and asks to treat `##`/`###`/`####` equivalently. It's labeled 
enhancement
.
👍 1
l
@fresh-machine-37269 now open a PR fixing it
👀 1
f
✅ Done! Opened the PR: github.com/OpenHands/software-agent-sdk/pull/4632 It relaxes 
HEADING_RE
in 
.github/scripts/check_issue_readiness.py
to match any heading of two or more hashes (
^#{2,}\s+
), so 
##
(h2) sections are treated the same as 
###
(h3). Added tests covering h2 splitting and h2-headed enhancement/bug bodies. The change is verified working locally and fixes #4631.
c
I approved the PR. This bit me today too. And actually was going to relax the headings myself when I realized that if it was opened by hand template would make it a non-issue so I downgraded my PR to be a message only. But that this happened again in less than 12 hours makes the case for it.
🙏 1
@limited-student-10747 This won't totally address this issue though because if an agent writes the issue and the user is not a maintainer they won't be able to apply the bug or feature label and the user will still get the not ready for dev message.
My message warns the user that a maintainer will have to make the change but if this is actually blocking a user flow we may want to relax the label requirement.
c
If the user uses bug or feature template, it should auto-apply, but maybe the agent can’t do that?
c
Not with gh command.
I suppose there may be a way to use an issue template from gh but the agent isn't going to do that by default.
c
looks like the all-hands-bot adds the labels. at least that's what it did for me on github.com/OpenHands/OpenHands/issues/16797 and github.com/OpenHands/software-agent-sdk/issues/4577
5 Views
Open in Slack
PreviousNext
Powered by