Hey :wave: 3 PRs stacked on top of each other to ...
# proj-automation
m
Hey ๐Ÿ‘‹ 3 PRs stacked on top of each other to lay the groundwork for webhooks in the automation service. Please review them in the listed order: 1. refactor: extract a transport-neutral accept_event() from the webhook handler 2. feat: replace the parse-only source registry with a provider descriptor and verifier registry 3. feat: persist accepted events to deduplicate redeliveries and expose events that matched nothing Tested DB migration, changes are not breaking other (cron) automations, small fake webhook automation, in the VM and locally. For instance, everything works fine.
โœ… 1
l
Tangentially related comment, have you tried the official github stacked PRs? theyโ€™re pretty handy: github.github.com/gh-stack
m
No but I should do that....
๐Ÿ‘ 1
@quick-window-91705 Thanks for the reviews. I answered your comment ๐Ÿ™‚
โœ… 1