https://docs.all-hands.dev/ logo
Join Slack
Powered by
Cleaning up some of our review practices and crite...
# proj-agent
l
Cleaning up some of our review practices and criteria to standardize across our main 5 repos. Merged: • Software Agent SDK #4587:github.com/OpenHands/software-agent-sdk/pull/4587 The OpenHands PR is approved and queued for automatic squash merge once its remaining requirements complete: • OpenHands #16834:github.com/OpenHands/OpenHands/pull/16834 Remaining PRs: • Automation #369:github.com/OpenHands/automation/pull/369 ◦ No review submitted yet. • TypeScript Client #356:github.com/OpenHands/typescript-client/pull/356 ◦ Reviewed with`COMMENTED`, not approved. • Extensions #498:github.com/OpenHands/extensions/pull/498 ◦ Reviewed with`COMMENTED`, not approved.
c
At least OpenHands repo already had? 😅 Previous section
It seems, also, that a PR added new duplicate lines:
May I ask, what LLM was the reviewer agent using? I see it approved happily
On the other hand, on the other PRs, hah! “Worth merging” - but didn’t approve it 😂
l
I think it might be kimi-k3 now
c
Ah good to know 🤔 It didn’t notice redundancies anywhere
Actually I think it was still GLM, unless you did something different for the reviewer run: https://openhands-ai.slack.com/archives/C0BLWB8PQ3B/p1787579114458809?thread_ts=1787578227.517159&channel=C0BLWB8PQ3B&message_ts=1787579114.458809 Most of what I intuit about GLM is that it's a pretty solid reviewer, so I guess being careful about docs might need a nudge in agents.md or reviewer or custom reviewer
l
I recently tried to fix our automation so it automatically loads our custom review guidelines, but I’m a bit confused as it seems to have not been reflected? I’ll need to check this again (cc @modern-fireman-99755)
aha 1
m
Perhaps was me after yesterday VM outtrage... Let me give a look... so we want kimi for PR review right?
Ok it was me... I will fix it
l
Actually the thing I’m more interested in is why we’re not auto-loading the custom review guidelines
m
Do you mean the one which we do have in the repo? Let me give a look
👍 1
c
I would suggest to keep GLM, maybe 5.3 when possible, if you don't have strong feelings about it
l
Yeah
2 Views
Open in Slack
PreviousNext
Powered by