LLM provider connections. Would love a :eyes: on ...
# proj-agent
m
LLM provider connections. Would love a šŸ‘€ on these two • sdk github.com/OpenHands/software-agent-sdk/pull/4492 • canvas github.com/OpenHands/OpenHands/pull/16616
c
Left a tiny question on the SDK PR. This looks good! We could use the agent's help to review the details - they can be good at finding corner cases
šŸ‘€ 1
h
@quick-window-91705 could you take a look at these today if you get the chance?
c
Just for clarity, I read the entire SDK PR, and the agent flagged some implementation issues. The canvas PR is in draft; though I took a quick look at that too, and I’ll need my agent to set it up for me 😹 I think there are a couple of CI failures, as well - though mock LLM tests might be flaky
šŸ¤” I think the agent’s findings here are nits, just would be nice for REST API robustness
m
@calm-artist-7206 I addresses yours and the agents concerns please re review.
This my second take at this feature, first take was much more complex and every agent pass just made it more complex. Decided to keep it minimal as possible.
ā¤ļø 1
c
I basically like it and my thoughts are more around the PR, than the PR itself: I think maybe we should aim to remove now the obsolete-ish api keys in LLM profiles, so that we have a single source of truth of how to connect to a provider. šŸ¤” Anything, in the PR or follow-ups, that can help move that forward, would be great! I'm guessing we kind of can’t right now, until the Cloud also has Provider Connections, right?
Ah, I see you made changes and right now CI fails
šŸ™
One thing I found helpful in understanding a PR is a small skill that tells the agent to show the human <%5Bhttps%3A//github.com/smolpaws/smolpaws/blob/main/.agents/skills/show-me/SKILL.md%5D(https://github.com/smolpaws/smolpaws/blob/main/.agents/skills/show-me/SKILL.md)|ā€œbeforeā€ and ā€œafterā€ like this> skill (or something like that) I think we have also some instruction somewhere telling the LLM to make a quick design doc in the temporary
.pr/
directory and link it via
<http://htmlpreview.github.io|htmlpreview.github.io>
Ah, found it: here It's part of the PR template, but the agent doesn’t seem to listen to it much 🫣