https://docs.all-hands.dev/ logo
Join Slack
Powered by
PR to delete dead-code: <github.com/OpenHands/Open...
# proj-agent-canvas
m
🔥 1
🙌 3
@calm-artist-7206 -3000 lines 🙂
🙌 1
c
Soo yummy! 🤣
There's more in Notes, too!
Btw this kind of PR is low risk, easy to fix if it breaks anything anyway, so imho this you could self approve one way or the other. Of course , I’m happy to find out we're doing this!
As long as you are willing to deal with any issues if any arises 😀
m
i double checked and it seems safe to delete
👍 1
c
Let's go! 💃
m
I'm blocked by the validate PR description 😞
c
cc @limited-student-10747 Even as we investigate further, could we please make it optional? Thinking it shouldn’t really block us…
l
But how else would we get to see @modern-fireman-99755’s nice picture of Mont Blanc? 😅 (agreed, i’ll set it as optional)
🤣 1
c
I didn’t even realize - now I see 😂
l
Sorry, it’s probably Matterhorn not Mont Blanc?
c
I was just about to say I’m going to be so disappointed if it’s not Mont Blanc 😅
m
🫣 I thought no one looks at the description.
c
Ahh, could we please also disable the setting to require updated branch for merge? The PR should auto-merge now, except it’s waiting for a human to press ‘update’ and run all over again through CI… This one was in 
agent-canvas
and IMHO it made sense at the start, but now the codebase is more stable, and I think we always see in main or at release PR time, if anything happens
Ah, sorry! Actually it wasn’t required
I provoked another run of “PR description check” and then it auto-merged
3 Views
Open in Slack
PreviousNext
Powered by