https://docs.all-hands.dev/ logo
Join Slack
Powered by
I'm seeing a bunch of perf issues in 1.12.0. I thi...
# proj-agent-canvas
w
I'm seeing a bunch of perf issues in 1.12.0. I think Graham may have fixed them? e.g. I'm getting this log about 10x/second Are we close to a new release?
l
a new release is warranted, I think we can start one
working on it
🙌 1
It seems that we’ve had a more serious problem that caused LLM calls to not be able to be made in parallel: • github.com/OpenHands/OpenHands/issues/16459 • github.com/OpenHands/software-agent-sdk/pull/4473 I’m still testing the fix, but intuitively this seems to explain the issue much more clearly than my previous fix.
@modern-fireman-99755 or @millions-crayon-32880 if you could take a look I might try to cut a new SDK release before releasing agent canvas. This is a pretty bad problem as any moderate to slow LLM would cause the agent server to basically become single threaded
m
ok... starting from the sdk part
🙏 1
Accepted the sdk PR. Just a couple of nits. it's pretty nice 🙂
🙏 1
l
Thanks for taking a look quickly!
w
Aha I was thinking this was the case!
I thought maybe anthropic was rate limiting me
do we have the ability to run cheap loadtests on concurrent convos?
l
Not now, but seems like something we should add!
👍 1
bumping sdk version on typescript client and automations: • github.com/OpenHands/typescript-client/pull/341 • github.com/OpenHands/automation/pull/332
@fresh-machine-37269 these are simple version bumps, do you think we could approve them? if so, please leave an approving review
👀 1
f
l
@modern-fireman-99755 it seems that our github token is out of rate limit, just FYI
f
⏳ Still working — this is taking longer than this run allows. Follow along at the link above; mention me again for an update.
Both PRs look good to me! I reviewed the diffs in detail: • typescript-client#341 — SDK 1.41.0→1.42.1 bump. Auto-generated schema changes are backward-compatible: new optional 
conversation_worktree_root
field on 
InitRequest
+ deprecation annotations on 
modify_params
(the concurrent LLM call fix). Docs and image pin updated consistently. • automation#332 — pure version bump of `openhands-sdk`/`openhands-workspace` 1.42.0→1.42.1 in 
pyproject.toml
+ 
uv.lock
only. One caveat: the GitHub token available to me belongs to 
all-hands-bot
, which is the PR author, so GitHub won't allow a formal APPROVE review. I left a comment review on both PRs with my assessment instead. If you need a formal approval to satisfy branch protection, someone with a different account would need to click approve. ✅
l
@fresh-machine-37269 additionally look at Robert's comment that we should have concurrent conversation load tests in software-agent-sdk, open a ready-for-dev issue there
👀 1
f
🤖 On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
Open in Slack
PreviousNext
Powered by