<@U093U7MJ44B> can you review these PRs. :pray: T...
# proj-agent-canvas
b
@millions-afternoon-47582 can you review these PRs. 🙏 This updates to the version widgets in settings and the left nav github.com/OpenHands/OpenHands/pull/16343 feat(conversations): add tag chips, overflow, and hovercard labels github.com/OpenHands/OpenHands/pull/16346
m
Hello @breezy-kilobyte-39430, I will review these pull requests today. Thank you very much! thankyou
Hello @breezy-kilobyte-39430, I've merged the first pull request and left a comment on the second pull request. Thank you very much! thankyou
b
The tags are off by default, so you need to turn them on in the filter dropdown.
m
I enabled it. However, I'm still experiencing the issue. thankyou
@breezy-kilobyte-39430 You can refer to the video below for more information. thankyou
b
Yeah, I'm trying to trace the issue now. strangely it was all looking and working fine and now that I've pulled the branch it's even showing tags that weren't there originally and the icons are mismatched. So I'm getting something different from you...
Look at it on cloud
let me fix some of theses issues, I'll let you know when done
m
@breezy-kilobyte-39430 The feature works correctly when connected to the OpenHands Cloud backend, as shown in the image below. However, we're still seeing the issue when it's connected to a local backend. thankyou
The video above, which demonstrates the issue, was recorded while connected to a local backend. In contrast, the image below, which shows the feature working as expected, was captured while connected to the OpenHands Cloud backend thankyou
b
Yeah, I found that as well. I also found that some of the new tags duplicate information already in the metadata chips such as the Repo/branch / workspace. This was an issue with the original tags feature that was first merged that I didn't catch before—I didn't turn on the repo and branch metadata when working on it.
❤️ 1
thankyou 1
All to say "not my fault" 😉 but I'll fix it now.
❤️ 1
thankyou 1
m
If bandwidth is a concern, I suggest keeping the scope focused on displaying the badges when connected to both the local and OpenHands Cloud backends. Once that's complete, we can merge the pull request. Any remaining issues can be tracked separately through additional GitHub issues thankyou
At the moment, the only remaining issue related to your work is that the badges are not displayed when connected to a local backend. Once that's resolved, we should be able to move forward with merging the pull request thankyou
b
The issue i just caught though is the Tags toggle had a second copy of repo/branch/workspace that I hadn't noticed before. I've removed them.
❤️ 1
thankyou 1
I've commited and pushed updates, try again when you can @millions-afternoon-47582
Also, did my other PRs get merged from last week?
m
Hello @breezy-kilobyte-39430, The issue is still occurring. The tags are still not displayed after creating conversations when connected to a local backend. Please refer to the video below for more details. Thank you very much! thankyou
I also observed that the tags are not displayed when connected to a cloud backend.
b
Can you try and diagnose the issue? I can't reproduce it.
m
I’ll continue working on the pull request and address the issue. Thank you very much! thankyou
I've updated the pull request and merged it thankyou
Also, did my other PRs get merged from last week?
@breezy-kilobyte-39430, I left a few comments on some of your pull requests. I'll continue reviewing the remaining ones and work toward getting them merged, so there's no need for you to take any further action at this time. Thank you very much! thankyou