https://docs.all-hands.dev/ logo
Join Slack
Powered by
Since we are doing a lot of cleanups, I wonder if ...
# proj-agent
c
Since we are doing a lot of cleanups, I wonder if two test workflows, condenser tests and api-compliance tests, should be on label? • 
condenser-test
label • 
api-compliance-test
label github.com/OpenHands/software-agent-sdk/pull/4204 Personally I feel the first may be useful; the second I'm not so sure. 🤔
m
I thought I deleted the first one or?
c
I think you deleted their automated schedule... or something like that, the caller
So the workflows still exist, but nothing calls them
m
ah ok... so yes I will delete them 🙂
c
The condenser tests?
m
I mean the workflow not the tests
c
So we shouldn't keep them on-label?
The condenser tests are written like integration tests, and the other two kinds of integration tests we can run them: • on label • or, automatically on release PRs The PR above proposes to put the condenser tests on label too. I don't think they're necessary on release PRs. (same for API compliance tests)
m
or make them integration tests? oR?
c
I mean, we have split integration tests into "integration" and "behavior" (and "condenser") tests, for the sole purpose of avoiding to run ALL unless necessary
m
but this could be actually interesting. Because condenser bugs are always so painfull
c
Idk; now that we no longer run integration tests often, they're only on-label and on release PRs, ... I guess we could merge them all ...
Yes
m
but I don't know how good are these condenser tests. I never looked inside I have to admit
nod 1
2 Views
Open in Slack
PreviousNext
Powered by