Can i get a review for 2 fixes for agent-canvas: -...
# proj-agent-canvas
m
Can i get a review for 2 fixes for agent-canvas: • github.com/OpenHands/OpenHands/pull/16200 • github.com/OpenHands/OpenHands/pull/16198 Thanks :)
c
Approved the first, with concerns about this weird bypass though https://github.com/OpenHands/OpenHands/pull/16200#issuecomment-5142766973 Please correct me if I'm wrong!
m
mmmh I was looking into this. Given github.com/OpenHands/OpenHands/issues/15563 is the accepted design and commits to profiles as the sole source of behavior config (no global-default fallback), I'd avoid feature-flagging profiles off. My suggestion: • Merge the PR as an immediate consistency fix, • github.com/OpenHands/OpenHands/issues/16205 is the follow-up • once it lands, the default special case in
useCreateConversation
can go away entirely, since the toolset/skills half of the gap is already resolved via github.com/OpenHands/software-agent-sdk/issues/3967 What do you think? I can add a point into github.com/OpenHands/OpenHands/issues/16205 such that we don't forget to delete the special case
useCreateConversation
👀 1
c
Perfect, thank you! 15563 makes a lot of sense! Yes, we can try this… My feeling that we could disable it is really only due to some confusions existing today, but it’s okay…
m
Ok cool... I updated the issue so we don't forget about that & merged the PR
thanks on a stick 1