Hey :wave: I've opened a PR to fix the multiple m...
# proj-agent-canvas
m
Hey 👋 I've opened a PR to fix the multiple messages issue with streaming. I tested it live with a few different models and didn't see the duplicate messages anymore (even with GPT, which was causing the issue before on my side). However, another pair of eyes would be great if anyone has some time! github.com/OpenHands/agent-canvas/pull/1865
c
I see your agent adopted the design from mine. I think it should work, yes. I closed the other PR. Generally, though, not in this case, sorry, I don’t mean in this case: generally, if I may suggest, we could instead just review or commit on the existing PR. It’s an unwritten guideline in an OSS project that earlier PRs should be preferred. Sometimes, for example, I was simply continuing various PRs, commit on it if I think it needs more, and take it cross the finish line. Please don’t get me wrong! Again, I don’t mind or care in this case. I haven’t got to test it myself, my agent claims it did, but the sequential nature of streaming makes me uncertain it manages to test it correctly. Thank you for picking it up!
m
Ah sorry... I didn't check that you were already working on that. I just pick the issue I wrote 2 weeks ago, let the agent gave me a first draft and started to working on that. 🫣
ah now I checked that you are cited in the summary 🙂
c
We need to do better on information on existing PRs. Right now, there aren’t many on agent-canvas (or agent-sdk), but once in openhands/openhands, I think we need to not miss contributors work. At high velocity AND high popularity… What if: • we add in AGENTS.md that when it makes a PR it needs to check and to add first section in PR description, in blue, the related/existing PRs • or, make an automation which, on PR open from org, check and post a comment - also in blue (somehow we need to see it 😅) • … or something
And no worries in this case, I think more in perspective
m
Iwe add in AGENTS.md that when it makes a PR it needs to check and to add first section in PR description, in blue, the related/existing PRs
This could be a solution.
c
@nutritious-balloon-65098 make it so
m
or in the PR template. Better
n
I'm on it! can track my progress here.
m
Or the PR template is described in the AGENTS.md?
c
yes, i think it is
n
Implemented and committed as
3388821
(
chore: require related PR disclosure
). Changes: • Added an
AGENTS.md
rule to search for existing PRs and prefer earlier contributor work. • Added
## Existing / Related PRs
as the first agent-editable PR section. • Rendered its contents in a blue GitHub
NOTE
alert. • Updated the PR validator to reject missing, empty, unquoted, misplaced, or duplicate sections. • Added 8 focused validator tests and runs them in the PR-description workflow. • Left the protected
HUMAN:
section and checkbox unchanged. Validation: 8 tests passed; Python compilation and
git diff --check
passed. The worktree is clean. Would you like me to push this branch and create a PR, keep the commit local, or follow another Git workflow?
c
@nutritious-balloon-65098 yes do it, nondraft
n
m
@calm-artist-7206 I fix the problem your reviewer discovered
👀 1