OpenHands

Add some cloud funnel analytics to better understand whether people are successfully logging in to cloud cc <@U093U7MJ44B>
• <https://github.com/OpenHands/agent-canvas/pull/1828|Agent Canvas #1828>
• <https://github.com/OpenHands/typescript-client/pull/283|TypeScript client #283>


Hello <@U06PEF04LEQ>,

I've approved both pull requests and left one comment on the typescript-client pull request.

Thank you very much! :thankyou:

Can we consider first <https://github.com/OpenHands/agent-canvas/pull/1590|https://github.com/OpenHands/agent-canvas/pull/1590>  ? Or something like it. The telemetry/analytics gives a black screen on browsers with ads disabled

The PR removes it from root, while keeping it for cloud

<@U090ER7JPHA> address Hiep's comment and TL;DR Engel's change wrt what telemetry data will be collected when

I'm on it! Graham Neubig can <https://app.all-hands.dev/conversations/ac3194a19268457891b22e23bdc13fb5|track my progress here>.

Thanks Engel for the discussion! I think overall that PR is a good fix to make sure that adblockers don’t break things and that we only collect info if people consent, but I had one question about the conditions on showing the consent dialog — i think we should show it all the time

Hey <@U06PYTVAES1>, really sorry, but I noticed that a lot of stuff was pretty poorly engineered and broken in telemetry (e.g. we had two paths), so I did a big refactor to make things more clean. This created merge conflicts in your PR again, and possible fixed some of the issues that your PR was trying to fix too: <https://github.com/OpenHands/agent-canvas/pull/1590|github.com/OpenHands/agent-canvas/pull/1590>

Happy to re-review when it’s non-conflicted again.

I think yours might still be fixing an issue of the black screen with the ad blocker, but I haven’t had a chance to check it. Anyway, it might be worth closing it and then if it’s still a problem opening a follow-up. Apologies for the churn!