https://docs.all-hands.dev/ logo
Join Slack
Powered by
<@U0A9RLDPQU8> - any thoughts on the error in rele...
# proj-agent-server
f
@modern-fireman-99755 - any thoughts on the error in releasing github.com/OpenHands/software-agent-sdk/pull/3931 ? Without direction I'd be inclined to revert github.com/OpenHands/software-agent-sdk/pull/3889
m
Give me 15 min
f
All good - I know it's late for you
c
I think reverting it might not work either, the PR existed because the workflow failed
Could we just side step this whole thing for integration tests, defining models manually, rather than shared with 
evaluation
repo? I think there’s redundancy then, but oh well, still better than this maybe
m
I changed the token to private because I thought was the correct one to access private repo and I didn't want to create a new token just for that.
c
Oh, sorry, I’m not blaming you! We didn’t find the best way to do this, clearly: I think maybe we should rename the private token to 
DO_NOT_USE_IN_PUBLIC_REPOS
so that the agent will warn us next time
m
Now I'm not on my computer... perhaps: @strong-ice-84145 could change the token to have the correct one? Or I can do it tomorrow morning if there is no pressure for the release
defining models manually, rather than shared with 
evaluation
repo
This is actually a good idea. Perhaps is a better approach. Because now we need someone which can change the token
@calm-artist-7206 I follow your suggestion: https://github.com/OpenHands/software-agent-sdk/pull/3935 So they are working 🙂
c
when you ran, you forced a single model?
m
yes
👍 1
c
Merged, sorry I normally let authors merge, they know best if they want another tweak or test or whatever, this time my agent was supposed to wait for the merge so I did it
🙏
m
no problem
Did you re-started the relevant test on the release branch?
c
no
m
Should I'
?
c
Started now!
There was another example failing, apparenrly a fluke
m
Ok the workflow is still failing because it is using the one in main and not the one we pushed 🫣 What is the best solution here? Should I also open a PR in main with the new workflow?
c
ah! yes I just noticed I merged on branch 😅
Lets merge to main
I think, the same commit, pr to main, merge -> cherry pick it for good measure (should do nothing) -> re-run the 2 labels We don’t need test examples, again, if we don’t make any other changes
test-examples worked (well enough)
m
ok let's do that
i will do
gratitude thank you 1
@calm-artist-7206 you are fast 🙂
🤠
s
can I get an SDK PR in before release? ready in 20 minutes.....
👍 1
c
Oops, in the meantime my agent was watching for the merge and re-added the labels 😅
I removed the block, I’m actually like half asleep so maaaybe it’s not the best idea to mess with PRs 😅
m
sorry... which block?
c
On the release PR
m
ah oki
s
I addressed the review comments on github.com/OpenHands/software-agent-sdk/pull/3934!
✅ 1
c
Still half asleep, but I don’t think this is risky
(famous last words)
s
I am doing a stress test/final validation of it before merging
c
we can cherry pick it without re-running tests. As usual, it might be a good idea to be on standby if the sky falls today/tomorrow 🫠 but it won’t (famous last words again!)
s
found a bug! will merge once fixed
lolsob 2
❤️ 2
merged!
m
Can you cherry pick the change?
s
done!
m
who is going to merge? 🙂
✅ 1
s
FYI I'm making an OpenHands version bump PR!
c
Should be automatic?
m
it is not at the moment
c
By the way, with release-please, do we continue to open PRs on merge… ah, I think yes? it depends on merge event
6 Views
Open in Slack
PreviousNext
Powered by