https://docs.all-hands.dev/ logo
Join Slack
Powered by
Hey, adding workflow in typescript-client to have...
# proj-agent-server
m
Hey, adding workflow in typescript-client to have merge-driven release: https://github.com/OpenHands/typescript-client/pull/230 (similar to the one in the sdk) If it is good. i would like to release a new version of the typescript-client today for: • testing the workflow • I need a new version for a feature
c
Love this! Left a tiny comment
By the way, for what account is that new token?
m
It is for the all-hands-bot. I hope is the correct one (@quick-window-91705?)
c
Just so you know, my ideal end state is like this: • 
openhands-agent
runs on open source, public repos, with no perms on private repos • 
all-hands-bot
runs on private repos. The separation Simon made is a big step, and, it’s not the end of the road 🙏
Is there a reason why we don’t restart using 
openhands-agent
? It seems to have similar perms atm
m
Sincerely, I don't know.
c
@limited-student-10747 could we slowly restart using 
openhands-agent
account? It seems both bot accounts are in the org, with similar perms, so I think maybe it would work. One major reason is that people out there are still trying to call it, for example I took this screenshot recently. They receive no answer, no clue, nothing - at the moment. I mean, people assume that openhands agent, the account that is named with 
openhands
, and it autocompleted by GitHub when you try to tag, is available in the community. Which… makes sense to me Could we make that real?
m
I believe a person not in the org cannot call the agent anyway, or?
c
I mean, even if we make a tiny automated reply like, “To use OpenHands Agent, you can do x”, it’s still a little bit better?
Also, this use case works today, but it works for all-hands-bot: • the reviewer agent runs on their PR • the PR author uses GitHub “re-review” on top right
Please let me take a step back. I didn’t mean to suggest to solve everything at once. This PR only adds a new token for use in GitHub actions. It has nothing to do with tagging it or cloud. Just this tiny detail: the new token is minted from 
all-hands-bot
account. Can we mint it from 
openhands-agent
account? It’s OK if we cannot…
m
So should we already merge. Just to be sure the workflow works?
l
Hey @modern-fireman-99755, actually we recently switched to use trusted publishing for pypi packages, and I think we should do that here too, it’s more secure. https://docs.npmjs.com/trusted-publishers Let me ping you on another (private) thread that we have about this
👍 1
m
@limited-student-10747 Actually, we are already using this, see the PR: • https://github.com/OpenHands/typescript-client/pull/190 • https://github.com/OpenHands/typescript-client/pull/192
@able-napkin-92802 after your comment: I changed the release process to use the action you mentioned. Could you give a look to see if everything is correct? Do we need to do something? What I mean is: is the release branch automatically created?
a
Will take a look at it shortly! The release branch is automatically created
2 Views
Open in Slack
PreviousNext
Powered by