https://docs.all-hands.dev/ logo
Join Slack
Powered by
Would love a review on these two PRs to enable onb...
# proj-agent-canvas
l
Would love a review on these two PRs to enable onboarding into frontend-only mode on the cloud so we can move towards using the agent canvas instead of the legacy frontend in openhands cloud/enterprise: • https://github.com/OpenHands/agent-canvas/pull/1385 • https://github.com/OpenHands/agent-canvas/pull/1389
ping on this, would anyone on that app team like @millions-afternoon-47582 or @quick-window-91705 be able to take a look? I have tested the code myself and it seems to work fine
m
Hello @limited-student-10747, Thank you for sharing these. I will review the pull requests and follow up if I have any questions or feedback. Thank you very much! thankyou
🙏 1
I have reviewed both pull requests and left my comments. Thank you very much! thankyou
🙏 1
l
Thanks @millions-afternoon-47582, I think that the comments have been resolved.
m
Hello @limited-student-10747, For this pull request (#1389), I pulled the latest code from your branch and followed the same reproduction steps. Unfortunately, the issue mentioned in my previous review comment is still occurring on my end: #1389 (review) Thank you very much! thankyou
l
Got it, I'll check again, sorry!
thankyou 1
m
No problem at all! I've attached a video to my GitHub comment that walks through the steps to reproduce the issue. Thank you very much! thankyou
l
OK, thanks @millions-afternoon-47582! I fixed it now, and will follow up with a few small formatting fixes
👀 1
m
Which command did you use for your manual testing? I'm currently using the following command, but I'm still seeing the same issue.
Copy code
node /Users/hieple/Documents/openhands/agent-server-gui/scripts/static-server.mjs --lock-to-cloud <https://app.all-hands.dev>
l
Thanks @millions-afternoon-47582, did you run 
npm run build
before running that command?
m
I forgot to run 
npm run build
earlier—my apologies for that. I've retested the pull request and found three issues. I've documented them in a GitHub comment on the PR for your review. Thank you very much! thankyou
l
Thanks so much for all your checks of this @millions-afternoon-47582, I have manually tested myself but you have a better eye for detail than I do 😭 I believe it should be fixed now: https://github.com/OpenHands/agent-canvas/pull/1389
m
Hello @limited-student-10747, I’ve added a question to the pull request and approved it Thank you very much! thankyou
l
Thanks so much, merged it in!
❤️ 1
thankyou 1
Open in Slack
PreviousNext
Powered by