Chore to bump agent server broke some E2E tests - ...
# proj-agent-canvas
f
Chore to bump agent server broke some E2E tests - both update and E2E fixes are here: https://github.com/OpenHands/agent-canvas/pull/1315 🙏
c
The code in the PR re-adding the app proxy should not be necessary
The PR description says this, which is also not accurate:
litellm_proxy/*
profiles may be stored with
base_url: null
(the server manages the proxy URL internally and omits it from the stored config). Without a corresponding frontend fix, saving such a profile from the Basic tab would strip the proxy URL and strand the profile (issue #1146 regression).
The regression happened long before the change in agent-sdk that made
openhands/
prefixed models inline with any other provider
So this doesn’t seem correct
f
Ugh - I guess I'll have to revert that one - it should have just been a simple dependency bump, but there were test failures.
c
Yes, could we revert the PR and add only the other things you intended?
f
TBH a 2 hour process with multiple rounds of github actions just for a dependency bump is 🤬🤬🤬
c
The
openhands/
provider behavior should be exactly the same as any other provider, and client applications should not do anymore all those workarounds re-translating it back
Yes… the e2e tests are many and time consuming
q
although to be fair historically we’ve faced regressions from what we expected to be simple dependency bumps
oh oops i approved the pr hoping that youd be able to continue working on it but seems like auto merge squash was enabled
we also have some trivial unit tests that fail on version bumps which we can prob get rid of or soften the checks
working on a new PR that removes that base url handling and fixes the e2e accordingly
Not so much worried about Tims PR since its preserving behavior from before wrt base url handling So instead of revert I created a followup that cleans it all out: https://github.com/OpenHands/agent-canvas/pull/1321
✅ 1
❤️ 1
oh also linked the wrong pr, working on this deterministic approve to running only subsets of e2e tests (https://github.com/OpenHands/agent-canvas/pull/1286) although pre-release it would good to verify that all pass
❤️ 1
c
That would be great! ^^
Yes, we can add them all for release-only
🙌 1