https://docs.all-hands.dev/ logo
Join Slack
Powered by
Hey folks, could someone review my PR when you get...
# proj-agent
a
Hey folks, could someone review my PR when you get a chance? https://github.com/OpenHands/agent-canvas/pull/1263 It fixes an issue where editing a cloud backend when switching to a custom domain (like an OpenHands Enterprise instance) can silently change it to a local backend, which breaks auth/API calls afterward
m
wrong channel 🙂 this should go in #C06QT0AGY4W I will review it 😉
🙏 1
a
ugh sorry, so use to this channel, my bad, thanks
m
@average-processor-75195 just one question: why did you change the workflow pr-artifacts.yml?
Ok got it... it was your agent. The commit msg is:
Copy code
fix: skip comment posting for fork PRs in pr-artifacts workflow
The check-pr-artifacts job was failing on fork PRs because it tried to
post a comment without write permissions. This adds a fork PR check to
skip the comment posting step for fork PRs, similar to the existing
check in the cleanup-on-approval job.
So it was trying to make the CI green 🙂 The PR LGTM but I will reverse this last commit
a
Thanks man, I am new at this
m
Should I revert it and merge?
a
Yes, that is fine with me
👍 1
2 Views
Open in Slack
PreviousNext
Powered by