I'd love a 👀 on ACP secrets cleanup https://github.com/OpenHands/software-agent-sdk/pull/3652 ACP would read secrets stored on llm.api_key llm.base_url. But ACP has credentials for the CLI itself, not llm, so ACP should use secrets from the

agent_context.secrets

, so I am removing this secrets channel. This change is non-breaking for Agent-Canvas and OpenHands that dont populate llm secrets for acp.

I think you need 5 minors by repo policy. @calm-artist-7206 can confirm. Otherwise, LGTM

Yes but I really want this parameter out for acp release.. 😅 this way I can remove it together with acp_env and the ACP secrets code is clean on release

😅 What exactly is the risk here?

Updating deprecation to 33