https://docs.all-hands.dev/ logo
Join Slack
Powered by
Can I get :eyes: on those 2 PRs? They will help to...
# proj-agent
s
Can I get 👀 on those 2 PRs? They will help to bring ACP to cloud? I validated them by running ACP agents locally • route provider creds through secret_registry, not acp_env https://github.com/OpenHands/software-agent-sdk/pull/3464 • surface structured errors on ACP spawn/auth/init failure https://github.com/OpenHands/software-agent-sdk/pull/3462 @limited-student-10747 @modern-fireman-99755 FYI Less important PR but still a good optimization • dedup tool-call progress at the source (O(n²)→O(1)) https://github.com/OpenHands/software-agent-sdk/pull/3465
c
Hah, to be honest I actually love these optimizations, like the 3rd PR!
I sent my agent to figure out and report on the API compatibility fail
s
the api compatibility fail is not from my PRs. But after some thought I think I will introduce a new compatibility fail: remove acp_env. It's only used in clients for secrets when it shouldn't. I think ACP is early enough that we dont need a migration?
c
You're right, I quick-fixed the API compatibility fail, and it should pass now for everyone, other PRs were affected too
Agree on acp_env
s
mmh but I can't remove acp_env without having the CI breakage fail for all subsequent PRs until the next release? will investigate
for https://github.com/OpenHands/software-agent-sdk/pull/3464 I'll deprecate acp_env in this PR so it can be deleted in a futur PR
thanks on a stick 1
c
That sounds good! Sorry I think I enabled automerge but you can probably stop it
s
You are thinking of another PR. You did not review this one yet ttps://github.com/OpenHands/software-agent-sdk/pull/3464
c
Sorry!
😅 me dizzy
s
bump could someone review this remaining PR? https://github.com/OpenHands/software-agent-sdk/pull/3464 Thanks!
👀 1
c
I was just looking at it actually! 😅
Making also a small sanity check with the agent but LGTM!
s
btw this is an intermediate step so clients using acp_env dont break anything, but after migration another PR will be needed to clean things up and only keep registry, issue here https://github.com/OpenHands/agent-canvas/issues/1039
Two follow-ups to make sure clients don't use acp_env • OpenHands https://github.com/OpenHands/OpenHands/pull/14620 • benchmarks https://github.com/OpenHands/benchmarks/pull/734 However for benchmarks this is a big sdk jump v1.16 -> v1.24. I added a codex bump + trigger 4 benchmarks (acp + non-acp) to vaidate that the changes dont break anything
Another follow-up from the ACP tool event dedup. Canvas doesn't need to dedup anymore • https://github.com/OpenHands/agent-canvas/pull/1027 Validated locally with video
acp dedup.mp4
✅ 1
c
For the benchmarks PR, I have a little side concern with the package updates: there’s this crazy supply chain attacks series running amok on github
I set off my agent to investigate from that point of view a bit
2 Views
Open in Slack
PreviousNext
Powered by