`EventService._setup_stats_streaming` acquires the...
# proj-agent
s
EventService._setup_stats_streaming
acquires the lock and deadlocks ACP: issue Fix: https://github.com/OpenHands/software-agent-sdk/pull/3349 @limited-student-10747 @quick-window-91705 I am also investigating why the deadlock is happening
👀 1
seems like the PR I made is OK for a hot-fix The real fix is making ACPAgent.astep native-async; the cross-thread reentry class goes away for all future callsites.
q
Cool would you like to take that forward?
s
I made a PR and iteratively fixed all the bots reviews and it yields this fat PR • https://github.com/OpenHands/software-agent-sdk/pull/3358 +1000 -100 Since it's too big and ugly I ask OH to make a more concise PR that solves the issue with minimal code • https://github.com/OpenHands/software-agent-sdk/pull/3359 • Initially +500 -50 • But the bot keeps mentionning edge cases that need fixing -> complex if statements + edge case tests • Back to a fat PR +1000 -100 track... Not sure how to deal with this kind of scenario, maybe the complexity is unavoidable here?
l
The other solution is “ignore the bot” if you think that its advice isn’t great
But if you agree then maybe the complexity is unavoidable? Feel free to send it for human review if you want
s
for async deadlock edge cases it's not that easy to know if the bot is right or overly cautious 😛 will review the comments and try a slimmed PR
👍 1