https://docs.all-hands.dev/ logo
Join Slack
Powered by
<@U07TE39J96U> I think we may want to disable or i...
# proj-agent-canvas
l
@quick-window-91705 I think we may want to disable or improve the snapshot tests, i'm getting these errors on virtually every PR
👀 1
w
snapshot tests are great but they can be really painful
there are some 3p services where you can upload the snapshots and see the diff on their site, instead of checking into source control
we could probably vibecode something like that
e.g. on vercel
q
perhaps we can keep for parts that arent changing so frequently for now, like the onboarding flow which we’re unlikely to qa as often too also img diffs can be found as part of the CIs artifacts, to see what has changed
w
should we just do the CI artifacts instead of checking images in, and post a link to them?
q
yeah that sounds great!
l
thanks both!
q
https://github.com/OpenHands/agent-canvas/pull/482 Fix for this The PR diffs show up as a github comment (to do this we add the snapshots to the 
.pr
directory which get's wiped out once the pr is merged, and the baseline snapshots come from the artifacts from the latest commit on main)
Actually pushed a fix, see this github comment which includes the images https://github.com/OpenHands/agent-canvas/pull/482#issuecomment-4461914782
Upon feedback we've changed the snapshot tests so that a) the snapshots aren't checked into the repo as to avoid merge conflicts, and b) appear as a github comment with results indicating which ones are the same, new, and/or changed All the details for this are in agent.md so openhands knows how to work with the tests; please let me know whether this helps going forward
🙏 2
w
can we turn off the need for branches to be up to date before merging now?
q
i dont think so, we'd want the snapshots to compare against the latest baselines on main before merging
w
fair
7 Views
Open in Slack
PreviousNext
Powered by