Can we enable the setting where you cannot merge a...
# proj-agent-canvas
q
Can we enable the setting where you cannot merge a PR until CI is passing
🙏 1
👀 1
l
i could've sworn I turned this on last night
q
Ah maybe just need to add snapshot tests as part of the required CI
l
no, it was disabled completely, we had no branch protection
👍 1
one thing though, the snapshot tests seem to break very frequently. i haven't looked at them carefully, but are we sure that they're preventing enough errors to be worth it?
q
looking into that now
👍 1
The tests themselves don't seem flaky, just that the CI was failing in an obvious way but was merged anyways
l
ok got it