https://docs.all-hands.dev/ logo
Join Slack
Powered by
<@U06PEF04LEQ> <https://github.com/OpenHands/agent...
# proj-agent-canvas
q
@limited-student-10747 https://github.com/OpenHands/agent-canvas/pull/387 breaking up the PRs for llm profiles Here is the first PR for the API layer (agent is working on the initial bot review)
Going to merge this as its low stakes change and OH bot has approved
👍 1
l
happy to take a look at any follow-up ones
👍 1
m
@quick-window-91705 if needed you can pass the prs to me so i can work on it tomorrow…
👍 1
q
@limited-student-10747 @modern-fireman-99755 last PR for llm profiles https://github.com/OpenHands/agent-canvas/pull/393 I merged two prior to this The openhands review bot ran out of funds so it failed to complete. However, the latest review it had left had a minor recommended change which I've fixed, and I also QAed profiles thoroughly so I feel pretty good about the changes
Vasco I think the PRs left for profiles are for model switching from within a conversation (via a dropdown or 
/model
prompt) and possibly also giving the agent a tool to switch models on the fly
l
I think maybe those are both already implemented in the SDK? I'll take a look at the final PR
Hmm, @quick-window-91705 I wasn't able to get it to work locally... got an error like this https://allhandsai.slack.com/archives/C08L97A3XN1/p1778632906037499?thread_ts=1778632782.569549&amp;cid=C08L97A3XN1
q
Hmm it was working for me, will look into it
I think you may need to regen your OH LLM key in cloud to get around it, which is unrelated to the LLM profile PR
m
@quick-window-91705 I reviewed the PR and found a couple of problems. I know I’m being a bit of a nitpicker, but I believe it’s better to fix these now so we don't have to worry about them later. I'm not blocked by your PR. In fact, I’m going to check out your branch to create the 
/model
switch command and the button. Then, I’ll create my PRs targeting your branch.
PS: most of the issues I raised are problems I already had with LLM profiles in 
OpenHands/OpenHands
. So I believe you can just copy/paste the solution from there.
Actually I will start to fix them 🙂 and then left you as review if I did a good job 😉
I opened this PR against your branch to fix the comments I left: chore(profiles): UI polish, shared validation, onboarding integration There is attached a small video to show that the comments/issues are addressed.
✅ 1
q
Thanks a bunch! PR LGTM
m
State of LLM-profiles in canvas: There are 3 PRs: • A: feat: LLM profiles route integration (PR C) (your PR) • B: feat(chat): add /model slash command for LLM profiles • C: feat(chat): add switch-profile button next to input The flow is: C -> B -> A -> main The PRs B and C should be good. Just double check that we have the feature that the PR are adding also in SaaS There is also a PR of @curved-angle-80449 to port profiles in SaaS (feat: Add org-level LLM profiles for SaaS users) and here is the PR to test the deployment Preview: OpenHands PR #14406 . However, I still cannot access the deployment. So once it is tested it should be good.
q
@limited-student-10747 will you be performing QA/review and merge the PRs above at your convenience?
l
I can do that, i'm blocking this right now, right?
It's on my list for today but I'm doing several things at once
q
not super urgent, whenever you merge it lmk and I can add some tests and cut another alpha release
2 Views
Open in Slack
PreviousNext
Powered by