Hey <@U093U7MJ44B>: here's a big PR here to remove...
# proj-agent-canvas
l
Hey @millions-afternoon-47582: here's a big PR here to remove "v1" from agent-canvas: Remove obsolete V1 terminology by neubig 路 Pull Request #71 路 OpenHands/agent-canvas It's straightforward but huge. I think now is a good time to do it before it goes into prod and we need to worry about backward compatability
m
Hello @limited-student-10747, I will review this pull request. Thank you very much! thankyou
馃檹 1
l
Sorry @millions-afternoon-47582, actually please wait. I realized that the merge didn't go well so I'll fix
thankyou 1
OK @millions-afternoon-47582, I think it's ready now!
thankyou 1
c
@limited-student-10747 fyi, i just turned on sub-agent reviews on agent-canvas, so once you addressed the conflicts, you could ask sub-agent to do another round of reviews (which would be more comprehensive for such a large change) https://github.com/OpenHands/agent-canvas/commit/b17351a95fdfa0941eca2ade2087f86c4bc70466
l
cool, how do i do that?
c
Just merge from main and re-request review from all-hands-bot 馃檪
馃憤 1
l
Hi @millions-afternoon-47582 (and @chilly-france-44439) I'm wondering if we should just tear off the bandaid and get this in: Remove obsolete V1 terminology by neubig 路 Pull Request #71 路 OpenHands/agent-canvas It keeps going out of date with new PRs because it touches every file, so it might be best to just merge it and then fix any small issues afterwards
m
I am reviewing the pull request now. I will not merge any other pull requests until this one has been merged. I apologize for the delayed review. Thank you very much! thankyou
l
No worries at all, thank you! I know it's huge
m
@limited-student-10747, I have approved and merged the pull request. Thank you very much! thankyou
l
Thank you!
鉂わ笍 1
m
I also verified your pull request locally using all the scenarios from the demo meeting to ensure that nothing is broken. Thank you very much! thankyou
馃檹 1
c
we should take your demo video and convert them into E2E tests in agent-canvas repo 馃槃
鉂わ笍 2
actually @millions-afternoon-47582, do you have the zoom meeting transcript somewhere? i"d be happy to try set that up
鉂わ笍 1
m
I don't have one, but Ash and Robert are the hosts of the demo meeting. They may have the recorded video and transcript available thankyou
l
awesome idea both!
鉂わ笍 1
thankyou 1
c
@purple-thailand-64770 could you help share meeting summary / transcript with me? 馃檹
maybe recording would be fine too!
p
Need to figure out how to have those auto-share out... I can send you the recording link though. I didn't capture a transcript on my end.
馃憤 1
c
would appreciate the recording link!
p
Trying something - think you should have access now?
c
didn't see anything in my email nor zoom app 馃槥
do you got any link?
p
Sent!
馃檶 1