<@U06QJHRBLQG> were you working on moving critic s...
# proj-agent
l
@chilly-france-44439 were you working on moving critic stuff into the SDK too? https://github.com/OpenHands/software-agent-sdk/pull/2620 I have that old PR, but maybe it's obsolete with your work
c
opps i thought i merged the PR facepalm I think we can still merge this
l
thanks!
c
@limited-student-10747 btw, have we ever got the settings to work in our CLI yet or no? 🤔
l
i think we’re not supporting the cli at the moment so i haven’t spent time on it
👍 1
c
Then i'll get this PR working & merged first
https://github.com/OpenHands/software-agent-sdk/pull/2620#issuecomment-4354396315
I found a design issue in the current refinement flow:
CriticMixin._check_iterative_refinement()
now builds the follow-up prompt directly through
IterativeRefinementConfig.build_followup_prompt()
, which bypasses
CriticBase.get_followup_prompt()
and any critic-specific overrides such as
APIBasedCritic.get_followup_prompt()
.
I realize there's more issue in this PR's design. I've convert it to draft and I will tweak it so it fits our Critic's abstraction.
l
Sure, please go ahead!
c
@limited-student-10747 done & approved the pr! feel free to merge when it looks right to you https://github.com/OpenHands/software-agent-sdk/pull/2620
l
Looks good! When CI works I’ll merge