OH already approved this, but I'd like someone fro...
# proj-agent-canvas
q
OH already approved this, but I'd like someone from the FE team to take a look https://github.com/OpenHands/OpenHands/pull/14077 When a conversation is archived and the user opens it, we see a bunch of loading indicators even though the conversation will never resume. This is particularly a bad experience for automation run related conversations, as they are archived immediately and serve read-only purpose. This PR makes a read only view of the conversation (following the same pattern as that for public sharing conversations) to make it a better/less distracting experience when opening archived conversations
❤️ 1
h
I was just testing this the other day! I didn't realize the archived conversation wouldn't ever load so this is a great fix. Since this is the same UI as sharing I think its good. Any fixes there would then reflect here. Otherwise, I would suggest making things disabled instead of removing them. Others may have stronger opinions 😄
acknowledged 1
q
maybe cc @millions-afternoon-47582 for review
m
I will review this pull request later today or early tomorrow. Thank you very much! thankyou
ty 1
q
Thanks for the feedback Hiep, I've left a reply
m
Hello @quick-window-91705, Thank you for your response. Before I proceed with reviewing the pull request again, it would be helpful to have @breezy-kilobyte-39430 review the output. Hello @breezy-kilobyte-39430, could you please take a look at the demo screenshot and share your feedback at your convenience? Thank you very much! thankyou
b
If we are currently just using the same UI for a shared conversation then do that for now. I don't want to delay this. it would be more ideal to have a max width on the conversation (not full screen).
thankyou 1
q
@millions-afternoon-47582 have you had a chance to review the code?
m
Hello @quick-window-91705, I have approved the pull request. Thank you very much! thankyou
ty 1