Review request for customer-support tagged issue:
...
# proj-agentc
curved-angle-80449
04/18/2026, 1:12 AMReview request for customer-support tagged issue:
https://github.com/OpenHands/software-agent-sdk/pull/2873
feat: Add per-conversation secrets support for MCP config variable expansion
✅ 1
curved-angle-80449
04/18/2026, 12:17 PMThanks very much @limited-student-10747! Fixes posted!
l
limited-student-10747
04/18/2026, 12:43 PMThanks! What did you think about the comment about possibly get_all_secrets() not being necessary? The reason why I’m a little concerned about this is that I’m not sure if we want to encourage a pattern where we expand all secrets into plain-text strings outside of the secret store. Even if it’s safe in this instance, I’m thinking about future-proofing against mistakes in the future.
nod 1
c
curved-angle-80449
04/18/2026, 12:49 PMMakes sense.
curved-angle-80449
04/18/2026, 12:49 PMI'll make that change.
👍 1
curved-angle-80449
04/18/2026, 2:06 PMReady for another look. Thanks again for your help with this:
https://github.com/OpenHands/software-agent-sdk/pull/2873#issuecomment-4273816010
l
limited-student-10747
04/18/2026, 2:31 PMThanks for the revisions, approved!
c
curved-angle-80449
04/18/2026, 2:33 PMReally appreciate your advice and review on this. Thank you!
curved-angle-80449
04/18/2026, 3:22 PMAnother reviewer found a security concern which has now been addressed but this requires a minor API change caught by our breakage checks. https://github.com/OpenHands/software-agent-sdk/pull/2873#issuecomment-4273946750 I am not sure how to handle the CI checks. OpenHands is suggesting merging with the two failing checks but wanted to run that by @limited-student-10747 or @calm-artist-7206 first.
👀 1
curved-angle-80449
04/20/2026, 6:59 PM@modern-fireman-99755 If you wouldn't mind giving https://github.com/OpenHands/software-agent-sdk/pull/2873#issuecomment-4274224420 another look before we merge, Engle and I would appreciate it.
👍 1
✅ 1
3 Views