Been blocked from using CLI for a while due to thi...
# proj-cli
q
Been blocked from using CLI for a while due to this, when prompted to update the settings I can't hit enter, can't Ctrl-C out, have to kill the process.
c
@nutritious-balloon-65098 please create an issue on OpenHands/OpenHands-CLI, repro the issue, and fix it,
/verify
on the new PR until the review bot approves
n
I'm on it! Xingyao Wang can track my progress here.
Final Summary Request Checklist • Create an issue on OpenHands/OpenHands-CLI → #669 • Reproduce the issue → Confirmed via automated test that Ctrl+C, Ctrl+Q, and Ctrl+D are all non-functional on the SettingsScreen modal. Root cause: Textual's
ModalScreen
has a default
ctrl+c → screen.copy_text
binding that overrides the App's quit binding, and `ctrl+q`/`ctrl+d` don't propagate through modals at all.
• Fix the issue → Added
force_quit
bindings and
action_force_quit()
to all 4
ModalScreen
subclasses (SettingsScreen, ExitConfirmationModal, SwitchConversationModal, ConfirmationSettingsModal). Updated 4 snapshot SVGs to reflect the new
^c Quit
in the footer.
•
/verify
on the new PR until the review bot approves
→ PR #670: 11/11 CI checks green, review bot verdict:
✅ Worth merging. Conciseness The changes are minimal and focused — only the 4 modal screen files were modified (adding ~3 lines of BINDINGS + ~3 lines of
action_force_quit
each), plus 4 snapshot SVGs that naturally changed because the footer now displays the new key binding. No extraneous changes. No Outstanding Items All parts of the user's request have been fully addressed. The PR is marked ready for review and all verification layers have passed.