BTW, any concerns/objection in merging the codereview-roasted and codereview skill? Feels a bit tricky to maintain two sets of code review skills facepalm (cc @limited-student-10747 @elegant-branch-54423)

yeah, go for it

works for me 👍

I wonder if it will work well 🤔 The roasted review has a way to channel some LLMs towards... I don't know how to name this, it's more of an intuition... that it's not the same as codereview. Maybe it's more attention to those principles that otherwise it's possible to treat a bit more superficially perhaps, but I could be wrong.

I kinda think that we could remove the linus persona and just specifically point out the points we want it to cover. We also now have the ability to A/B test code review using the laminar monitoring, so we could try different options

we could remove the linus persona

agree nod just keep those principals

Actually having the two separate ones has been very handy in conversations with customers about how to make skills their own and the Linus personality really resonates in story telling I do with them. If we are going to merge these I'll probably move them to another repo or to a different place in the same repo to preserve the teaching tool.

I'm fond of Linus too, because I feel that from the LLM perspective, it channels its response due to the history of Linus in a "stronger" direction - that just telling it principles might not go far enough; but that's just me being silly maybe. Or maybe it works a bit differently with LLMs more prompt-sensitive than Claudes are. So I see it, but most of us use Claudes so idk What if these skills would be part of a non-default marketplace?

I'll probably move them to another repo or to a different place in the same repo to preserve the teaching tool.

yeah, maybe it will be helpful to have these in another repo...

What if these skills would be part of a non-default marketplace?

The main pain point is that, whenever we add new stuff to codereview-roasted 😅 we have to do the same for codereview which is.. not pretty

I'm fond of Linus too,

And actually the personality is what helps the content be interesting and engaging to humans. And that HCI stuff is really important when it come to actually engaging with and getting benefit from the tool.

I start to suspect if it is because we removed the name "linus tovards"😅

My hypothesis is that maybe it brings with it a history stored in parametric knowledge, which then… hey 😅

We should run an AB test 😂