https://docs.all-hands.dev/ logo
Join Slack
Powered by
Is the review dashboard deployed on its latest ver...
# proj-documentation
c
Is the review dashboard deployed on its latest version? My agent tried to remove the bot from view
👀 1
@gentle-apple-32922 do you know if it was deployed? Maybe the fix didn’t work 😅
👀 1
g
It did deploy on March 18 when the merge happen. I looked at the vercel preview and the bot was a still there 😢 so it didnt' work 😅
lolsob 1
c
Sorry! @nutritious-balloon-65098 look at https://community-pr-dashboard.vercel.app , find the repo in OpenHands account from which it was deployed (similar name) and the latest PR by enyst. It didn’t do what it was supposed to do. Investigate and fix.
n
I'm on it! can track my progress here.
Summary of new work since the last update: - [x] Completed the fix - Added shared bot-login detection in 
lib/bots.ts
- Filtered bot reviewers out of reviewer-facing paths in: - 
lib/compute.ts
- 
lib/github.ts
- 
lib/employees.ts
- [x] Added regression coverage - Updated 
__tests__/lib/compute.test.ts
- Updated 
__tests__/lib/github.test.ts
- Verified bot reviewers are excluded from: - first-review calculations - requested-reviewer tracking - reviewer stats / rollups - categorized merged-review stats - [x] Verified the changes - Focused Jest suites passed - Targeted ESLint run had no errors; only pre-existing warnings remain - [x] Committed locally - Commit: 
918799b
— 
fix: exclude bot reviewers from dashboard metrics
Conciseness check: - [x] Changes are focused and directly related to the issue - [x] No obvious extraneous code changes remain - [x] The only non-code extra change was a small 
AGENTS.md
memory update, which was intentional repo memory per instructions If you want, I can now push this branch and open a PR, or leave it local.
c
yes push to enyst’s fork and open pr to upstream @nutritious-balloon-65098
n
Final summary of new work since my last update: - [x] Pushed the fix to enyst’s fork on branch 
fix/exclude-bot-reviewers-from-dashboard
- [x] Opened an upstream PR to 
OpenHands/community-pr-dashboard
- [x] Included the required AI disclosure in the PR body PR: - #30 — https://github.com/OpenHands/community-pr-dashboard/pull/30 Conciseness check: - [x] No extra code changes were added beyond the bot-reviewer filtering fix and its supporting tests/memory note - [x] No unrelated files were pushed as part of this PR So yes — the remaining request has been completely addressed.
g
will build preview on emoment
look good for stats but do we want the bot removed from the table at the bottom?
c
@nutritious-balloon-65098 remove the bot (s) also from the table at the bottom
n
g
I think the bots are removed. I just wondered if we would want to know if the all-hands-bot has reviewed a PR or not thinky spin
n
Final update since my last summary: - [x] Removed bot-authored PRs from the bottom dashboard table - [x] Updated the table’s displayed total so it now counts only non-bot PR rows - [x] Removed the Bot option from the Author Type dropdown for that table view - [x] Added regression coverage in 
__tests__/api/dashboard.test.ts
- [x] Ran relevant tests successfully: - 
__tests__/api/dashboard.test.ts
- 
__tests__/lib/compute.test.ts
- 
__tests__/lib/github.test.ts
- [x] Pushed the follow-up fix to the existing PR branch Conciseness: - [x] The new changes were focused and minimal for the request - [x] No extraneous feature work was added Git/PR status: - New commit pushed: 
3063f71
 — 
fix: hide bot PRs from dashboard table
- Existing PR updated: #30 https://github.com/OpenHands/community-pr-dashboard/pull/30
c
I was thinking, it doesn’t seem in scope in this page, we could and I’m sure we will have dashboards / views of some kind for automations?
Idk, it’s a different kind of question it answers
g
i am fine with anything if we wanna remove them all thats cool too
n
Final update since my last summary: - Reverted the follow-up change that hid bot-authored PRs from the bottom table. - Created and pushed revert commit 
780d340
 to the existing PR branch. - Updated PR remains: **https://github.com/OpenHands/community-pr-dashboard/pull/30** Checklist: - [x] Reverted the last commit as requested - [x] Pushed the revert to enyst’s fork / existing upstream PR branch - [x] Kept the earlier reviewer-metrics fix intact - [x] Did not make any additional unrelated changes Conciseness: - The new work was limited to a clean revert of the most recent table-hiding change. - No extra changes were kept beyond what was necessary to undo that last commit.
c
Oh, sorry, I misunderstood. You mean these? I… don’t know. I reverted the commit and let it be the status quo for now
g
i meant under reviewers do we need to know if the bot reviewed?
i queried software-agent-sdk only because i know the bot reviews these PRS
c
Did it exist before? I don’t see it here https://community-pr-dashboard.vercel.app
g
hmmm oh maybe not thinky spin
😅 1
c
🤷
g
Anyway, looks good to me in the vercel preview so merged 🙌
thanks on a stick 1
2 Views
Open in Slack
PreviousNext
Powered by