https://docs.all-hands.dev/ logo
Join Slack
Powered by
The pr still says changes requested. I can overri...
# questions
c
The pr still says changes requested. I can override this but is there a way to have the reviewer update the state of the pr to ready to merge?
c
You could add to PR description that if it thinks it's good to merge, then it should respond with a review with event APPROVED. I mean, it sounds like LLM randomness -ish, it could decide to override its own former event, or forget and just comment
You could also fix its prompt, for example the custom-pr-review markdown file (maybe I don't recall correctly the name, something like that)
IIRC: PR description does get into the prompt; and inline comments; but I think top-level comments maybe don't
(which is why I'd use PR description field to tell it to be nice)
c
I used the UI and prompted it to approve the review. The UI tried but it is using my token so it was not able to approve it because of github rules about approving your own requests. I think I would need to add a different user to act as openhands
c
Ah, yes
The same that asked for changes
Could you link the PR?
c
c
Thank you, please see this maybe, you could use a .md file to customize the agent's behavior and tell it to e.g. always add an 'event' to the review or 'approve' every time it thinks there are no major issues etc (but also, it always will, on all PRs not only your own) https://github.com/OpenHands/software-agent-sdk/tree/main/examples/03_github_workflows/02_pr_review#how-it-works
c
Do I add that to my pr review script for my repo?
Also is there a recommended way to add another user that represents open hands? I am working alone at the moment and have disabled the required reviewers.
c
To the repo, I believe in 
.agents/skills
, actually custom in the name works for the sdk repo https://github.com/OpenHands/software-agent-sdk/blob/main/.agents/skills/custom-codereview-guide.md
At least, though it’s probably a bit annoying… I think you can use a PAT from another account, instead of github token (it now uses the default github token so it posts as ‘github-actions’, but that depends on the token
2 Views
Open in Slack
PreviousNext
Powered by