Should we maybe make it required to pass the manda...
# proj-agentc
calm-artist-7206
03/20/2026, 11:26 AMShould we maybe make it required to pass the mandatory CI before merging? For example, I don't think this PR ran all CI:
https://github.com/OpenHands/software-agent-sdk/pull/2524
A kind of proof: it didn't get to run the creation of agent-server builds: the edit in the PR description with links to builds didn't have time to run.
Now I'm not sure how many checks are mandatory, but I do feel that in this case, only very few checks ran... š¤
There's basically no-risk in that PR, but for others it would maybe matter.
calm-artist-7206
03/20/2026, 11:30 AMThat said, there is another detail:
ā¢ I would slightly still prefer the griffe Python and oasdiff REST APIs checks to not be mandatory, so they don't block PRs as we keep refining them
calm-artist-7206
03/20/2026, 11:32 AMSame for the unresolved threads workflow, I feel it's best if it annoys agents, but doesn't really block humans
m
modern-fireman-99755
03/20/2026, 11:33 AMA kind of proof: it didn't get to run the creation of agent-server builds: the edit in the PR description with links to builds didn't have time to run.I believe this is because are not
requiredrequiredc
calm-artist-7206
03/20/2026, 11:34 AMI'm trying to say that I suspect things like SDK tests or cross tests are not mandatory for merging
š 1
m
modern-fireman-99755
03/20/2026, 11:37 AMYou can check in settings if they are mandatory to merge: https://github.com/OpenHands/software-agent-sdk/settings
I cannot check for that as I have just write permissions.
But I suspect yes, as you have the label required on these tests.
c
calm-artist-7206
03/20/2026, 11:38 AMAnother example
calm-artist-7206
03/20/2026, 11:38 AMIt looks like they ran, but they ran AFTER the merge
calm-artist-7206
03/20/2026, 11:38 AMMaybe that's good...
calm-artist-7206
03/20/2026, 11:39 AMI mean, if in 4 minutes the PR got merged, and this took 7 minutes, it's kinda fun how it compressed time š
calm-artist-7206
03/20/2026, 11:40 AMI don't have access to CI settings either
m
modern-fireman-99755
03/20/2026, 11:50 AMThe test you are speaking about is not required to merge a PR š So everything was fine
c
calm-artist-7206
03/20/2026, 11:58 AMOK... Interesting. Maybe we had so many speed improvements that it feels like too fast š
calm-artist-7206
03/20/2026, 1:29 PMYou must be right. I tried to pay attention and not many are required; and those time-consuming are not
3 Views