https://docs.all-hands.dev/ logo
Join Slack
Powered by
<@U06PYTVAES1> looks like the REST API breaking ch...
# proj-agent
w
@calm-artist-7206 looks like the REST API breaking changes check has been failing on main since your PR. Is this by design?
c
Yes, I added the CI enforcement then. REST compatibility is actually broken since PR 2190, another ACP PR. Which we may or may not revert: https://github.com/OpenHands/software-agent-sdk/pull/2451
👀 1
Please don't worry about it for other PRs though, it's not blocking PRs. For now... though I'm thinking maybe we'll get to make them mandatory.
👍 1
l
Having CI constantly fail is breaking my workflow, because it confuses the agents and they try to fix the problem. Is there a way we can fix this sooner rather than later? I don’t know if doing a minor version bump is the correct way to do it or what?
c
We can revert the PR, fix it and merge it after? cc: @strong-ice-84145
Normally, the policy we landed on, is like: • public API breaking changes should have a deprecation period of 5 releases • after that, the removal / change can happen, with a minor version bump
s
I think that's the simplest solution. We will also need to revert this 
evaluation
PR too https://github.com/OpenHands/evaluation/pull/311 but that's pretty trivial
l
If it’s not hard to fix the problem then we could also just fix the problem. But if it’ll take some work I think reverting would be OK
I also don’t want to slow down our benchmarking work though so 🤷
c
Revert + remerge is not like it's gonna take more than the fix really
👍 1
So I see the concern, but it's probably easy enough
👍 1
s
I approved your PR @calm-artist-7206
c
Thank you! Merged, updated.
Maybe it's good to ask for a human review too on something like this, it affects core interfaces, so, well - the agent may be cool, but the old-fashioned humans still have more context. For now! 😅
We won't for long, I can tell
s
@modern-fireman-99755 reverting your PR on evaluation https://github.com/OpenHands/evaluation/pull/312\
👍 1
> Maybe it's good to ask for a human review too on something like this, it affects core interfaces, so, well - the agent may be cool, but the old-fashioned humans still have more context. For now! 😅 Agreed! the change was a bit too big to be merged on bot reviews 😅
❤️ 1
Open in Slack
PreviousNext
Powered by