Am I correct in thinking that https://github.com/OpenHands/software-agent-sdk/pull/2133 introduced a breaking change that will prevent CLI releases that would include other fixes from software-agent-sdk until https://github.com/OpenHands/OpenHands-CLI/pull/548 is merged?

I think maybe we just had an SDK release, and didn’t have yet a CLI release?

@strong-ice-84145 looks like the breaking change was due to an upgrade on the acp package - i wonder if that is a must for ACPAgent? 👀

It's a must for ACP: we cannot have any telemetry without the latest acp version

Just to note, we added a CI check for next time we upgrade ACP, so that we know it can be a bit of a hurdle for downstream to adapt, and can notice and consider it. (We will be able to get CI to pass with some string in the PR description.)

I have to admit I did not pay enough attention to breaking changes in my PR. Will be more careful going forward. Perhaps I should make ACP an optional dependency for now to avoid similar issues in the future

Is this a fix we can get into CLI asap or should we rollback so that we can unblock other fixes for CLI?

Afaik the CLI is pinned to the former version of the SDK?

Yes but we have other CLI bugs that originate in software-agent-sdk that need to be fixed

I think bumping the CLI dependency to "agent-client-protocol>=0.8.1", should fix the problem

If that is all, should be easy to do.

this PR does it among other things https://github.com/OpenHands/OpenHands-CLI/pull/548/changes#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 Am making a separate PR solely for the acp bump

Perfect. I had talked to @quick-window-91705 about feat: implement Ctrl+C pause/interrupt flow and update SDK hash #548 last week and sounded like he didn't think it was ready.

actually its not trivial, working on a minimal PR but simply bumping the version is not enough