For the PR review extension, when the agent acknow...
# feedback
q
For the PR review extension, when the agent acknowledges that improvements can be made but are out of scope for the current the PR or changes are pragmatic considering the constraints, it should mark the item as acceptable instead of needs rework
@nutritious-balloon-65098 can you find the pr-review extension and modify the prompt so that we're considering this case pragmatic choices that don't require any changes should be marked with green emoji and considered acceptable
n
I'm on it! Rohit Malhotra can track my progress here.
## Summary of Changes I modified the
github-pr-review
skill to handle pragmatic choices that don't require changes. ### Checklist - Request Addressed: - ✅ Added 🟢 Acceptable label for pragmatic choices (green emoji as requested) - ✅ Added guidance explaining when to use it: out-of-scope improvements, pragmatic constraints, reasonable trade-offs - ✅ Included example:
🟢 Acceptable: This helper could be extracted to a shared utility, but keeping it inline is reasonable for this PR's scope.
- ✅ Updated Summary section to emphasize not blocking PRs for pragmatic choices ### Changes Made: File:
skills/github-pr-review/SKILL.md
- Added new priority label row to the table - Added "Pragmatic Choices" subsection with criteria and example - Updated Summary to include new step 4 ### Conciseness Check: - ✅ Only modified the single relevant file - ✅ No extraneous changes - ✅ Changes are minimal and focused on the request --- The changes have been committed locally. I need to push them to complete the task. Would you like me to push to the current branch (
openhands-workspace-4LjJbt6TjfVisP9g6gbYV8
) and/or create a pull request?
q
@nutritious-balloon-65098 open a draft pr with the changes
n
I'm on it! Rohit Malhotra can continue tracking my progress here.
## Summary I've completed your request to update the
github-pr-review
skill to handle pragmatic choices appropriately. ### Checklist - ✅ Found the PR review extension: Located at
skills/github-pr-review/SKILL.md
- ✅ Added 🟢 Acceptable priority label: For pragmatic choices that are reasonable trade-offs or out of scope - ✅ Added "Pragmatic Choices" subsection: Explains when to use the Acceptable label (out of scope improvements, pragmatic constraints, reasonable trade-offs) - ✅ Added example usage: Shows how to use the label in practice - ✅ Updated Summary section: Emphasizes not blocking PRs for pragmatic choices - ✅ Changes are concise: Only 19 lines added, 3 lines modified - no extraneous changes - ✅ Pushed to remote: Branch
openhands-workspace-4LjJbt6TjfVisP9g6gbYV8
- ✅ Created draft PR: https://github.com/OpenHands/extensions/pull/88 ### Key Change The skill now instructs the agent to mark pragmatic choices with
🟢 Acceptable
instead of requesting rework when improvements are acknowledged but are out of scope or represent reasonable trade-offs given project constraints.
c
The alternative is to sweet-talk it in replies to this 😅
q
LOL funnily enough i tried multiple times but it didnt work figured it deserves a system prompt level importance
😂 1