<https://github.com/OpenHands/OpenHands-CLI/pull/5...
# proj-cli
w
https://github.com/OpenHands/OpenHands-CLI/pull/562 We worked through a major QOL improvement before realizing there already was a PR in the pipe that solves a similar problem. I hope we didn't step on any toes by submitting the PR anyways as it also contained 5 bug fixes for some ugly crashes we encountered.
I also did a project index and architectural documentation which I use to save a ton of tokens with our agents having to re-analyze the repo every time. i'm not sure if this goes against best practices or etiquette, apologies if it does and I won't push things like that in the future.
Another thing, we try to leave a papertrail whenever possible, so I mention the url to the dev artifacts for this merge. All planning docs, and then artifacts generated throughout the development of everything in the PR. Let me know if you'd rather I not include that in the PR comments
l
Thanks @worried-salesclerk-85726, could you fix the failing CI checks?
w
Happily
@limited-student-10747 The one failing CI Check is due to different Python version (3.12.12 on GitHub Actions runner vs my 3.12.3) The snapshot test test_phase5_landing_screen passes on the clean, un-modified HEAD locally (Python 3.12.3). The CI failure was on Python 3.12.12 on a GitHub Actions Ubuntu runner. This is a known class of issue with Textual snapshot tests — different Python minor versions can produce different widget rendering (font metrics, ANSI escape handling). Do all contributors need to strictly maintain the same python version in their local environment as the github runner? I didn't see anything in the Contributing.md file, so I'm not sure how strict of a requirement this is
c
It's not a strict requirement, but CI needs to pass... 😅
we use
uv
which makes a lot of things easier
w
gotcha, so 6 of one, 1/2 dozen of the other.. I'll pin my local python to 3.12.3 then, unless y'all felt like it was time to Regenerate the snapshot in the CI environment. I also got some interesting pushback against some of the feedback in the PR comments from your agent. Part of what I am doing is migrating our companies custom claude framework over to openhands, including a fairly robust adversarial debate team of engineering agents. They got into a squabble about some of the issues raised by the openhand agent critiquing the PR. Will be interesting to see where some of the human agents weigh in on these points after I post some of teh rebuttals
let me knwo if that did it.. and thank you for your patience. first time contributing to a project here
f
So was index methodology added to the openhands repo - what information do you have that it helped with token optimization
@worried-salesclerk-85726
w
@creamy-egg-10724 - thank you for questioning this. I haven't done vigorous evals on this strategy in forever and what used to work in the past doesn't net a positive result today. I've removed those files from the repo entirely
@limited-student-10747 bump
l
rerequested from @calm-artist-7206 since he requested changes previously
c
Ohh I'm so sorry, I didn't! My agent did! 😂 🙏 Taking a look, but mostly I would love to know if @quick-window-91705 has major concerns, at least. It's a relatively wide ranging PR 🤔
w
Kind of morphed into one yea. Every round of feedback got a bit more broad. Was exciting for me knowing that I could contribute more and more but I get how it's going to increase the review overhead
@calm-artist-7206 - thanks for pushing this along and sorry again for being more trouble than I'm worth right now. I'm going to sit down and try to mirror as much of your workflows and tooling over here as I can to catch as much of this stuff on my end first.
Out of curiosity, if I mention the Openhands-agent in the command, do I also trigger/prompt it or is that limited to certain roles? Objective: • To identify faults and weaknesses in my workflow in order to strengthen my process and prevent similar issues from occurring in the future Task: • In regards to the Critical issue you listed. Read through our conversation history and previous feedback as well as file structure and comments and determine if there we're clear indicators or instructions requiring the Condensation Banner to persist when has_condensation is true, and update its text based on condensed_count even when _loaded_start_index is 0. Context:
[openhands_cli/tui/widgets/richlog_visualizer.py, Lines 1040–1064] Condensation banner disappears after full load: _update_banner_for_loaded_state() removes _banner_widget when _loaded_start_index reaches 0, even if _has_condensation is true. After the user pages up to load all post‑condensation events, the summary banner is removed and there is no indication of condensed prior context. This breaks the goal of preserving condensed history. Keep the banner when has_condensation is true, and update its text based on condensed_count even when _loaded_start_index is 0.
Hey @calm-artist-7206 / @limited-student-10747 - haven't forgotten about this entirely. The critiques and back and forth in this Pr led me to some major refactoring of my own framework. 21 days of refactoring apparently! Almost ready to turn it back on again and can revisit this.
Is there documentation about my question above? I'd love to get openhands in our PR's the same way you have it there
c
Oh, cool! You may want to see this https://github.com/OpenHands/software-agent-sdk/tree/main/examples/03_github_workflows/02_pr_review and the actual workflow action in extensions/ repo
I think it was hooked to openhands-agent at least as “ask review from” on a PR, but we kinda rarely use it like that, I forget ; I’m afraid it may need to be part of your repo though, to work like that
The ‘review-this’ label works, once you set up the workflow