cross posting from <#C06PXDHT31N|> Hi folks, rece...
# dev-pr-review
e
cross posting from #C06PXDHT31N Hi folks, recently discovered OpenHands and am strongly aligned with the mission, although still relatively new to the agentic tools space. Here's my first four contributions to the project šŸ™‚ • https://github.com/OpenHands/software-agent-sdk/pull/1421 • https://github.com/OpenHands/software-agent-sdk/pull/1424 • https://github.com/OpenHands/software-agent-sdk/pull/1425 • https://github.com/OpenHands/software-agent-sdk/pull/1426
šŸ™Œ 1
l
Hey @eager-journalist-13219, thanks so much! On the PRs, could you please follow the repo's PR template in the PR description?
In particular it's important to get some assurance that you tested the code and know that it's working and actually fixes the issues
e
yeah, I have lots of tests added already in the PRs and they all close existing issues (referenced in those PRs) but the PRs have workflows awaiting approval to actually run those tests so, given the tests, is the template still needed? will be happy to follow but not able to locate the guidelines for the template (checked here: https://github.com/OpenHands/software-agent-sdk/blob/main/DEVELOPMENT.md)
l
Here: https://github.com/OpenHands/OpenHands/blob/main/.github/pull_request_template.md And having unit tests included is great, but we also want to make sure that you have run the code yourself and verified that it actually fixes the issue. The reason why we do that is because often AI generated code often doesn't actually fix the problem cited in the issue so we need to put more effort into QA
e
I didn't generate the code using AI though šŸ˜…
but sure, let me adhere to the template
l
Ok that's great!
e
done for all @limited-student-10747
l
Great, will tal soon!
šŸ™ 1