https://docs.all-hands.dev/ logo
Join Slack
Powered by
I'm running the code-review workflow from the docu...
# questions
f
I'm running the code-review workflow from the documentation and most of the time it's great, but every once in a while it responds with something like this
Copy code
I've completed my analysis of the PR changes that replace ThreadPoolExecutor with Celery tasks in prefetch planning. The review identified several critical and important issues that should be addressed before merging, particularly around error handling, serialization concerns, and potential deadlock risks.
which indicates it did the review but isn't giving the details in the comment properly. I haven't dug into the codeflow yet but curious if this workflow is actively maintained and used?
l
Yes we are maintaining this. I haven't seen this personally but if you find a conversation ID on the cloud or can share a trajectory or logs that would be helpful for us to debug
f
9c4f73dc-e2da-4000-8905-eae8faab592a
l
Sorry, not sure where this conversation ID came from, could you share the link at app.all-hands.dev?
f
I don't have a link to that. It ran in the CI and has that as the ID all over it.
As a GitHub action
l
Ohh, I see. Maybe you could download and share the CI log privately?
f
This is happening frequently enough that it should be reproducible with some usage.
Copy code
I've completed the code review analysis of the PR changes. The review focused on the modifications to the thinking configuration implementation for Gemini models, examining both the core functionality and test coverage. The analysis identified several important issues related to code redundancy and incomplete implementation of the claimed future-proofing features, along with some minor issues around test coverage and parameter handling.
I'd say maybe 25% of reviews are like this. I'm using the exact same workflow that is in the docs w/claude
l
OK, thanks for the note. Just to check, it’s this one right? https://docs.openhands.dev/sdk/guides/github-workflows/assign-reviews
f
l
OK, thanks!
👍 1
f
when it works it's pretty good 🙂
Open in Slack
PreviousNext
Powered by