:oh_waveq: Hi err'body! :wave: Seeking some advice...
# proj-agent-canvas
b
oh waveq Hi err'body! 👋 Seeking some advice 🙏 Been working on a PR to fix this :
[Bug]: [UI] Settings page shows duplicate element IDs for React Aria controls (a11y/UX) #10555
I dug into the duplicate ID problem we’ve been seeing. The root cause appears to come from the HeroUI library itself. Their
Autocomplete
component is generating duplicate IDs, which breaks ARIA rules and accessibility. I wrote up a full bug report here:
<https://github.com/heroui-inc/heroui/issues/5738
|[BUG] - Autocomplete Generates Duplicate IDs in HeroUI v2.8.4, Breaking ARIA/Accessibility #5738>
Looking at the code..we'd have to update.. specifically these two files • settings-dropdown-input.tsx • model-selector.tsx While reviewing, I noticed areas we could improve to better align with HeroUI Autocomplete guidelines • *U*se the documented
items
or
defaultItems
pattern in
<Autocomplete>
instead of manual
.map()
. This keeps our usage aligned with HeroUI guidelines. • *S*tandardize on the controlled model (
selectedKey
+
onSelectionChange
)
. This makes behavior predictable and avoids mixing controlled and uncontrolled patterns. ❓ Would it make sense to spin up an enhancement PR instead to apply these changes? 🙏
highfive 1
f
Go for it!
b
Thanks for the blessings to move forward with this @freezing-spoon-14104 @wooden-umbrella-84098 teamspirit Just got back from a Disneyland vacay.. will definitely check this out.
📰 Some other news 📰 Looks like the HeroUI bug was picked up and there's a PR out to get it fixed excited fix(autocomplete): duplicate id in clear &amp; selector button #5750
f
Thank you so much! Hope you had a great time in Disneyland. I'm honestly shocked that the maintainers of HeroUI haven't addressed this issue sooner. It has existed since we first adopted the library (back when it was called NextUI) almost a year ago!
teamspirit 1
b
Happy to help! Helping out OpenHands is my first OSS experience.. don't know why I waited so long lol. Pretty cool to see folks from around the world, solving problems making cool stuff. I learned the hard way diving into this issue that it was a HeroUI thing not so much an OpenHands thing. But I learned! 💡
🙌 1